RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 21:27:36 +00:00
Code Issues Activity Actions

LibHTTP: Respect the 'Connection: close' header on keep-alive jobs

Browse source 
If the server responds with this header, we _must_ close the connection,
as the server is allowed to ignore the socket and not respond to
anything past that response.
Fixes some RequestServer spins.
This commit is contained in:
Ali Mohammad Pur 2021-09-30 12:19:54 +03:30 • committed by Andreas Kling
parent d16131b100
commit b0a9c5673e
13 changed files with 55 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibGemini/GeminiJob.cpp
View file

@ -58,13 +58,17 @@ void GeminiJob::start(NonnullRefPtr<Core::Socket> socket)
}
}
void GeminiJob::shutdown()
void GeminiJob::shutdown(ShutdownMode mode)
{
if (!m_socket)
return;
m_socket->on_tls_ready_to_read = nullptr;
m_socket->on_tls_connected = nullptr;
m_socket = nullptr;
if (mode == ShutdownMode::CloseSocket) {
m_socket->close();
} else {
m_socket->on_tls_ready_to_read = nullptr;
m_socket->on_tls_connected = nullptr;
m_socket = nullptr;
}
}
void GeminiJob::read_while_data_available(Function<IterationDecision()> read)

2
Userland/Libraries/LibGemini/GeminiJob.h
View file

@ -28,7 +28,7 @@ public:
}
virtual void start(NonnullRefPtr<Core::Socket>) override;
virtual void shutdown() override;
virtual void shutdown(ShutdownMode) override;
void set_certificate(String certificate, String key);
Core::Socket const* socket() const { return m_socket; }

2
Userland/Libraries/LibGemini/Job.h
View file

@ -20,7 +20,7 @@ public:
virtual ~Job() override;
virtual void start(NonnullRefPtr<Core::Socket>) override = 0;
virtual void shutdown() override = 0;
virtual void shutdown(ShutdownMode) override = 0;
GeminiResponse* response() { return static_cast<GeminiResponse*>(Core::NetworkJob::response()); }
const GeminiResponse* response() const { return static_cast<const GeminiResponse*>(Core::NetworkJob::response()); }