RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 12:17:35 +00:00
Code Issues Activity Actions

LibWeb: Make Element::set_shadow_root() disconnect any previous root

Browse source
This commit is contained in:
Andreas Kling 2022-03-16 00:26:40 +01:00
parent d2a99eded7
commit b1096c2ae4
4 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/DocumentFragment.h
View file

@ -29,7 +29,7 @@ public:
Element* host() { return m_host; }
Element const* host() const { return m_host; }
void set_host(Element& host) { m_host = host; }
void set_host(Element* host) { m_host = host; }
private:
// https://dom.spec.whatwg.org/#concept-documentfragment-host

5
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -382,8 +382,11 @@ void Element::set_shadow_root(RefPtr<ShadowRoot> shadow_root)
{
if (m_shadow_root == shadow_root)
return;
if (m_shadow_root)
m_shadow_root->set_host(nullptr);
m_shadow_root = move(shadow_root);
m_shadow_root->set_host(*this);
if (m_shadow_root)
m_shadow_root->set_host(this);
invalidate_style();
}

2
Userland/Libraries/LibWeb/DOM/ShadowRoot.cpp
View file

@ -15,7 +15,7 @@ namespace Web::DOM {
ShadowRoot::ShadowRoot(Document& document, Element& host)
: DocumentFragment(document)
{
set_host(host);
set_host(&host);
}
// https://dom.spec.whatwg.org/#ref-for-get-the-parent%E2%91%A6

2
Userland/Libraries/LibWeb/HTML/HTMLTemplateElement.cpp
View file

@ -13,7 +13,7 @@ HTMLTemplateElement::HTMLTemplateElement(DOM::Document& document, DOM::Qualified
: HTMLElement(document, move(qualified_name))
{
m_content = adopt_ref(*new DOM::DocumentFragment(appropriate_template_contents_owner_document(document)));
m_content->set_host(*this);
m_content->set_host(this);
}
HTMLTemplateElement::~HTMLTemplateElement()