RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:37:45 +00:00
Code Issues Activity Actions

LibJS: Port this_symbol_value() to NonnullGCPtr

Browse source
This commit is contained in:
Linus Groh 2023-04-15 16:06:52 +02:00
parent dd91f1a5a5
commit b110258848
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/SymbolPrototype.cpp
View file

@ -40,18 +40,18 @@ ThrowCompletionOr<void> SymbolPrototype::initialize(Realm& realm)
} }
// thisSymbolValue ( value ), https://tc39.es/ecma262/#thissymbolvalue // thisSymbolValue ( value ), https://tc39.es/ecma262/#thissymbolvalue
static ThrowCompletionOr<Symbol*> this_symbol_value(VM& vm, Value value) static ThrowCompletionOr<NonnullGCPtr<Symbol>> this_symbol_value(VM& vm, Value value)
{ {
// 1. If value is a Symbol, return value. // 1. If value is a Symbol, return value.
if (value.is_symbol()) if (value.is_symbol())
return &value.as_symbol(); return value.as_symbol();
// 2. If value is an Object and value has a [[SymbolData]] internal slot, then // 2. If value is an Object and value has a [[SymbolData]] internal slot, then
if (value.is_object() && is<SymbolObject>(value.as_object())) { if (value.is_object() && is<SymbolObject>(value.as_object())) {
// a. Let s be value.[[SymbolData]]. // a. Let s be value.[[SymbolData]].
// b. Assert: s is a Symbol. // b. Assert: s is a Symbol.
// c. Return s. // c. Return s.
return &static_cast<SymbolObject&>(value.as_object()).primitive_symbol(); return static_cast<SymbolObject&>(value.as_object()).primitive_symbol();
} }
// 3. Throw a TypeError exception. // 3. Throw a TypeError exception.
@ -63,7 +63,7 @@ JS_DEFINE_NATIVE_FUNCTION(SymbolPrototype::description_getter)
{ {
// 1. Let s be the this value. // 1. Let s be the this value.
// 2. Let sym be ? thisSymbolValue(s). // 2. Let sym be ? thisSymbolValue(s).
auto* symbol = TRY(this_symbol_value(vm, vm.this_value())); auto symbol = TRY(this_symbol_value(vm, vm.this_value()));
// 3. Return sym.[[Description]]. // 3. Return sym.[[Description]].
auto& description = symbol->description(); auto& description = symbol->description();
@ -76,7 +76,7 @@ JS_DEFINE_NATIVE_FUNCTION(SymbolPrototype::description_getter)
JS_DEFINE_NATIVE_FUNCTION(SymbolPrototype::to_string) JS_DEFINE_NATIVE_FUNCTION(SymbolPrototype::to_string)
{ {
// 1. Let sym be ? thisSymbolValue(this value). // 1. Let sym be ? thisSymbolValue(this value).
auto* symbol = TRY(this_symbol_value(vm, vm.this_value())); auto symbol = TRY(this_symbol_value(vm, vm.this_value()));
// 2. Return SymbolDescriptiveString(sym). // 2. Return SymbolDescriptiveString(sym).
return PrimitiveString::create(vm, TRY_OR_THROW_OOM(vm, symbol->descriptive_string())); return PrimitiveString::create(vm, TRY_OR_THROW_OOM(vm, symbol->descriptive_string()));