RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions

LibJS: Allow setting the length of an object with prototype Array

Browse source 
Before this it would always go through the native setter thus
 modifying the array but now you can set length to anything
This commit is contained in:
davidot 2021-06-25 16:57:12 +02:00 • committed by Linus Groh
parent b38fb418f8
commit b1441a47b1
2 changed files with 92 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

39
Userland/Libraries/LibJS/Runtime/Array.cpp
View file

@ -65,25 +65,50 @@ Array* Array::typed_this(VM& vm, GlobalObject& global_object)
JS_DEFINE_NATIVE_GETTER(Array::length_getter)
{
auto* array = typed_this(vm, global_object);
if (!array)
auto* this_object = vm.this_value(global_object).to_object(global_object);
if (!this_object)
return {};
return Value(array->indexed_properties().array_like_size());
// TODO: could be incorrect if receiver/this_value is fixed or changed
if (!this_object->is_array()) {
Value val = this_object->get_own_property(vm.names.length.to_string_or_symbol(), this_object);
if (vm.exception())
return {};
return val;
}
return Value(this_object->indexed_properties().array_like_size());
}
JS_DEFINE_NATIVE_SETTER(Array::length_setter)
{
auto* array = typed_this(vm, global_object);
if (!array)
auto* this_object = vm.this_value(global_object).to_object(global_object);
if (!this_object)
return;
// TODO: could be incorrect if receiver/this_value is fixed or changed
if (!this_object->is_array()) {
this_object->define_property(vm.names.length.to_string_or_symbol(), value, default_attributes);
if (vm.exception())
return;
return;
}
auto length = value.to_number(global_object);
if (vm.exception())
return;
if (length.is_nan() || length.is_infinity() || length.as_double() < 0) {
u32 val = length.as_double();
if (val != length.as_double()
|| length.is_nan()
|| length.is_infinity()
|| length.as_double() < 0
|| length.as_double() > NumericLimits<u32>::max()) {
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidLength, "array");
return;
}
array->indexed_properties().set_array_like_size(length.as_double());
this_object->indexed_properties().set_array_like_size(val);
}
}