From b157ab3f123bab19a7634d5c15fb579655a6f77c Mon Sep 17 00:00:00 2001
From: Linus Groh <mail@linusgroh.de>
Date: Thu, 8 Jul 2021 21:56:03 +0100
Subject: [PATCH] LibJS: Implement Temporal.Instant.prototype.epochMilliseconds

---
 .../LibJS/Runtime/CommonPropertyNames.h       |  1 +
 .../Runtime/Temporal/InstantPrototype.cpp     | 20 +++++++++++
 .../LibJS/Runtime/Temporal/InstantPrototype.h |  1 +
 .../Instant.prototype.epochMilliseconds.js    | 33 +++++++++++++++++++
 4 files changed, 55 insertions(+)
 create mode 100644 Userland/Libraries/LibJS/Tests/builtins/Temporal/Instant/Instant.prototype.epochMilliseconds.js

diff --git a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
index 95e6184f63..44c661e05e 100644
--- a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
+++ b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
@@ -113,6 +113,7 @@ namespace JS {
     P(endsWith)                              \
     P(entries)                               \
     P(enumerable)                            \
+    P(epochMilliseconds)                     \
     P(epochSeconds)                          \
     P(error)                                 \
     P(errors)                                \
diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.cpp
index 6210229718..815532ca4f 100644
--- a/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.cpp
+++ b/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.cpp
@@ -24,6 +24,7 @@ void InstantPrototype::initialize(GlobalObject& global_object)
     auto& vm = this->vm();
 
     define_native_accessor(vm.names.epochSeconds, epoch_seconds_getter, {}, Attribute::Configurable);
+    define_native_accessor(vm.names.epochMilliseconds, epoch_milliseconds_getter, {}, Attribute::Configurable);
 
     // 8.3.2 Temporal.Instant.prototype[ @@toStringTag ], https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype-@@tostringtag
     define_direct_property(*vm.well_known_symbol_to_string_tag(), js_string(vm.heap(), "Temporal.Instant"), Attribute::Configurable);
@@ -61,4 +62,23 @@ JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::epoch_seconds_getter)
     return Value((double)s.to_base(10).to_int<i64>().value());
 }
 
+// 8.3.4 get Temporal.Instant.prototype.epochMilliseconds, https://tc39.es/proposal-temporal/#sec-get-temporal.instant.prototype.epochmilliseconds
+JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::epoch_milliseconds_getter)
+{
+    // 1. Let instant be the this value.
+    // 2. Perform ? RequireInternalSlot(instant, [[InitializedTemporalInstant]]).
+    auto* instant = typed_this(global_object);
+    if (vm.exception())
+        return {};
+
+    // 3. Let ns be instant.[[Nanoseconds]].
+    auto& ns = instant->nanoseconds();
+
+    // 4. Let ms be RoundTowardsZero(ℝ(ns) / 10^6).
+    auto [ms, _] = ns.big_integer().divided_by(Crypto::SignedBigInteger::create_from(1'000'000));
+
+    // 5. Return 𝔽(ms).
+    return Value((double)ms.to_base(10).to_int<i64>().value());
+}
+
 }
diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.h
index dc9555c2f7..8f8c7985ec 100644
--- a/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.h
+++ b/Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.h
@@ -20,6 +20,7 @@ public:
 
 private:
     JS_DECLARE_NATIVE_FUNCTION(epoch_seconds_getter);
+    JS_DECLARE_NATIVE_FUNCTION(epoch_milliseconds_getter);
 };
 
 }
diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Instant/Instant.prototype.epochMilliseconds.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Instant/Instant.prototype.epochMilliseconds.js
new file mode 100644
index 0000000000..0b176124a7
--- /dev/null
+++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Instant/Instant.prototype.epochMilliseconds.js
@@ -0,0 +1,33 @@
+describe("correct behavior", () => {
+    test("basic functionality", () => {
+        expect(new Temporal.Instant(0n).epochMilliseconds).toBe(0);
+        expect(new Temporal.Instant(1n).epochMilliseconds).toBe(0);
+        expect(new Temporal.Instant(999_999n).epochMilliseconds).toBe(0);
+        expect(new Temporal.Instant(1_000_000n).epochMilliseconds).toBe(1);
+        expect(new Temporal.Instant(1_500_000n).epochMilliseconds).toBe(1);
+        expect(new Temporal.Instant(1_999_999n).epochMilliseconds).toBe(1);
+        expect(new Temporal.Instant(2_000_000n).epochMilliseconds).toBe(2);
+        expect(new Temporal.Instant(8_640_000_000_000_000_000_000n).epochMilliseconds).toBe(
+            8_640_000_000_000_000
+        );
+
+        expect(new Temporal.Instant(-0n).epochMilliseconds).toBe(0);
+        expect(new Temporal.Instant(-1n).epochMilliseconds).toBe(0);
+        expect(new Temporal.Instant(-999_999n).epochMilliseconds).toBe(0);
+        expect(new Temporal.Instant(-1_000_000n).epochMilliseconds).toBe(-1);
+        expect(new Temporal.Instant(-1_500_000n).epochMilliseconds).toBe(-1);
+        expect(new Temporal.Instant(-1_999_999n).epochMilliseconds).toBe(-1);
+        expect(new Temporal.Instant(-2_000_000n).epochMilliseconds).toBe(-2);
+        expect(new Temporal.Instant(-8_640_000_000_000_000_000_000n).epochMilliseconds).toBe(
+            -8_640_000_000_000_000
+        );
+    });
+});
+
+test("errors", () => {
+    test("this value must be a Temporal.Instant object", () => {
+        expect(() => {
+            Reflect.get(Temporal.Instant.prototype, "epochMilliseconds", "foo");
+        }).toThrowWithMessage(TypeError, "Not a Temporal.Instant");
+    });
+});