RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 15:17:45 +00:00
Code Issues Activity Actions

Shell: Use Node::kind() instead of Node::class_name() in formatter

Browse source
This commit is contained in:
AnotherTest 2020-10-14 19:25:40 +03:30 • committed by Andreas Kling
parent 738f512919
commit b1b202124c
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Shell/Formatter.cpp
View file

@ -140,7 +140,7 @@ void Formatter::visit(const AST::And* node)
{ {
will_visit(node); will_visit(node);
test_and_update_output_cursor(node); test_and_update_output_cursor(node);
auto should_indent = m_parent_node && m_parent_node->class_name() != "And"; auto should_indent = m_parent_node && m_parent_node->kind() != AST::Node::Kind::And;
TemporaryChange<const AST::Node*> parent { m_parent_node, node }; TemporaryChange<const AST::Node*> parent { m_parent_node, node };
with_added_indent(should_indent ? 1 : 0, [&] { with_added_indent(should_indent ? 1 : 0, [&] {
@ -370,7 +370,7 @@ void Formatter::visit(const AST::IfCond* node)
if (node->false_branch()) { if (node->false_branch()) {
current_builder().append(" else "); current_builder().append(" else ");
if (node->false_branch()->class_name() != "IfCond") { if (node->false_branch()->kind() != AST::Node::Kind::IfCond) {
in_new_block([&] { in_new_block([&] {
node->false_branch()->visit(*this); node->false_branch()->visit(*this);
}); });
@ -446,7 +446,7 @@ void Formatter::visit(const AST::Or* node)
{ {
will_visit(node); will_visit(node);
test_and_update_output_cursor(node); test_and_update_output_cursor(node);
auto should_indent = m_parent_node && m_parent_node->class_name() != "Or"; auto should_indent = m_parent_node && m_parent_node->kind() != AST::Node::Kind::Or;
TemporaryChange<const AST::Node*> parent { m_parent_node, node }; TemporaryChange<const AST::Node*> parent { m_parent_node, node };
with_added_indent(should_indent ? 1 : 0, [&] { with_added_indent(should_indent ? 1 : 0, [&] {
@ -465,7 +465,7 @@ void Formatter::visit(const AST::Pipe* node)
{ {
will_visit(node); will_visit(node);
test_and_update_output_cursor(node); test_and_update_output_cursor(node);
auto should_indent = m_parent_node && m_parent_node->class_name() != "Pipe"; auto should_indent = m_parent_node && m_parent_node->kind() != AST::Node::Kind::Pipe;
TemporaryChange<const AST::Node*> parent { m_parent_node, node }; TemporaryChange<const AST::Node*> parent { m_parent_node, node };
node->left()->visit(*this); node->left()->visit(*this);