RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:47:34 +00:00
Code Issues Activity Actions

LibTest: Handle test reporting in the a unique path

Browse source
This commit is contained in:
Michel Hermier 2021-12-15 09:20:38 +01:00 • committed by Brian Gianforcaro
parent 2f8fac3528
commit b1b94692e6
2 changed files with 30 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibTest/CrashTest.cpp
View file

@ -49,17 +49,23 @@ bool Crash::run(RunType run_type)
return do_report(Failure(WEXITSTATUS(status)));
}
if (WIFSIGNALED(status)) {
outln("\x1B[32mPASS\x1B[0m: Terminated with signal {}", WTERMSIG(status));
return true;
return do_report(WTERMSIG(status));
}
VERIFY_NOT_REACHED();
}
}
bool Crash::do_report(Failure failure)
bool Crash::do_report(Report report)
{
// If we got here something went wrong
const bool pass = report.has<int>();
if (pass)
out("\x1B[32mPASS\x1B[0m: ");
else
out("\x1B[31mFAIL\x1B[0m: ");
report.visit(
[&](const Failure& failure) {
switch (failure) {
case Failure::DidNotCrash:
outln("Did not crash!");
@ -70,7 +76,12 @@ bool Crash::do_report(Failure failure)
default:
VERIFY_NOT_REACHED();
}
return false;
},
[&](const int& signal) {
outln("Terminated with signal {}", signal);
});
return pass;
}
}

4
Userland/Libraries/LibTest/CrashTest.h
View file

@ -10,6 +10,7 @@
#include <AK/Function.h>
#include <AK/String.h>
#include <AK/Variant.h>
namespace Test {
@ -30,7 +31,8 @@ public:
bool run(RunType run_type = RunType::UsingChildProcess);
private:
bool do_report(Failure failure);
using Report = Variant<Failure, int>;
bool do_report(Report report);
String m_type;
Function<Crash::Failure()> m_crash_function;