RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:57:45 +00:00
Code Issues Activity Actions

LibRegex: Do not treat repeats followed by fallthroughs as atomic

Browse source
This commit is contained in:
Ali Mohammad Pur 2023-06-14 01:02:40 +03:30 • committed by Andreas Kling
parent 31c9fe5c32
commit b1ca2e5e39
2 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibRegex/Regex.cpp
View file

@ -995,6 +995,9 @@ TEST_CASE(optimizer_atomic_groups)
Tuple { "[^x]+y"sv, "ay"sv, true },
// .+ should not be rewritten here, as it's followed by something that would be matched by `.`.
Tuple { ".+(a|b|c)"sv, "xxa"sv, true },
// (b+)(b+) produces an intermediate block with no matching ops, the optimiser should ignore that block when looking for following matches and correctly detect the overlap between (b+) and (b+).
// note that the second loop may be rewritten to a ForkReplace, but the first loop should not be rewritten.
Tuple { "(b+)(b+)"sv, "bbb"sv, true },
};
for (auto& test : tests) {