RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:37:34 +00:00
Code Issues Activity Actions

LibJS: Stop early-returning on missing searchString in String.startsWith

Browse source 
A missing searchString is allowed by the specification and is treated
as js_undefined. ("undefined test".startsWith() => true)
This commit is contained in:
Idan Horowitz 2021-04-20 15:24:49 +03:00 • committed by Linus Groh
parent 81d7d68416
commit b1e5330e64
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/StringPrototype.cpp
View file

@ -179,11 +179,11 @@ JS_DEFINE_NATIVE_FUNCTION(StringPrototype::starts_with)
auto string = ak_string_from(vm, global_object); auto string = ak_string_from(vm, global_object);
if (string.is_null()) if (string.is_null())
return {}; return {};
if (!vm.argument_count())
return Value(false);
auto search_string = vm.argument(0).to_string(global_object); auto search_string = vm.argument(0).to_string(global_object);
if (vm.exception()) if (vm.exception())
return {}; return {};
auto string_length = string.length(); auto string_length = string.length();
auto search_string_length = search_string.length(); auto search_string_length = search_string.length();
size_t start = 0; size_t start = 0;