1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00

LibJS: Implement Intl.DurationFormat.supportedLocalesOf

This commit is contained in:
Idan Horowitz 2022-06-30 01:25:47 +03:00
parent b910183351
commit b20ef7d640
3 changed files with 64 additions and 0 deletions

View file

@ -5,6 +5,7 @@
*/
#include <LibJS/Runtime/AbstractOperations.h>
#include <LibJS/Runtime/Array.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/Intl/AbstractOperations.h>
#include <LibJS/Runtime/Intl/DurationFormat.h>
@ -27,6 +28,9 @@ void DurationFormatConstructor::initialize(GlobalObject& global_object)
// 1.3.1 Intl.DurationFormat.prototype, https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype
define_direct_property(vm.names.prototype, global_object.intl_duration_format_prototype(), 0);
define_direct_property(vm.names.length, Value(0), Attribute::Configurable);
u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.supportedLocalesOf, supported_locales_of, 1, attr);
}
// 1.2.1 Intl.DurationFormat ( [ locales [ , options ] ] ), https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat
@ -137,4 +141,19 @@ ThrowCompletionOr<Object*> DurationFormatConstructor::construct(FunctionObject&
return duration_format;
}
// 1.3.2 Intl.DurationFormat.supportedLocalesOf ( locales [ , options ] ), https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.supportedLocalesOf
JS_DEFINE_NATIVE_FUNCTION(DurationFormatConstructor::supported_locales_of)
{
auto locales = vm.argument(0);
auto options = vm.argument(1);
// 1. Let availableLocales be %DurationFormat%.[[AvailableLocales]].
// 2. Let requestedLocales be ? CanonicalizeLocaleList(locales).
auto requested_locales = TRY(canonicalize_locale_list(global_object, locales));
// 3. Return ? SupportedLocales(availableLocales, requestedLocales, options).
return TRY(supported_locales(global_object, requested_locales, options));
}
}

View file

@ -23,6 +23,8 @@ public:
private:
virtual bool has_constructor() const override { return true; }
JS_DECLARE_NATIVE_FUNCTION(supported_locales_of);
};
}

View file

@ -0,0 +1,43 @@
describe("correct behavior", () => {
test("length is 1", () => {
expect(Intl.DurationFormat.supportedLocalesOf).toHaveLength(1);
});
test("basic functionality", () => {
// prettier-ignore
const values = [
[[], []],
[undefined, []],
["en", ["en"]],
[new Intl.Locale("en"), ["en"]],
[["en"], ["en"]],
[["en", "en-gb", "en-us"], ["en", "en-GB", "en-US"]],
[["en", "de", "fr"], ["en", "de", "fr"]],
[["en-foobar"], ["en-foobar"]],
[["en-foobar-u-abc"], ["en-foobar-u-abc"]],
[["aa", "zz"], []],
[["en", "aa", "zz"], ["en"]],
];
for (const [input, expected] of values) {
expect(Intl.DurationFormat.supportedLocalesOf(input)).toEqual(expected);
// "best fit" (implementation defined) just uses the same implementation as "lookup" at the moment
expect(
Intl.DurationFormat.supportedLocalesOf(input, { localeMatcher: "best fit" })
).toEqual(Intl.DurationFormat.supportedLocalesOf(input, { localeMatcher: "lookup" }));
}
});
});
describe("errors", () => {
test("invalid value for localeMatcher option", () => {
expect(() => {
Intl.DurationFormat.supportedLocalesOf([], { localeMatcher: "foo" });
}).toThrowWithMessage(RangeError, "foo is not a valid value for option localeMatcher");
});
test("invalid language tag", () => {
expect(() => {
Intl.DurationFormat.supportedLocalesOf(["aaaaaaaaa"]);
}).toThrowWithMessage(RangeError, "aaaaaaaaa is not a structurally valid language tag");
});
});