RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:47:45 +00:00
Code Issues Activity Actions

Ladybird/AppKit: Select all text of location search field on focus

Browse source
This commit is contained in:
Bastiaan van der Plaat 2023-11-30 20:04:15 +01:00 • committed by Tim Flynn
parent e335354b30
commit b21ec0afac
1 changed files with 21 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Ladybird/AppKit/UI/TabController.mm
View file

@ -34,6 +34,24 @@ enum class IsHistoryNavigation {
No, No,
}; };
@interface LocationSearchField : NSSearchField
- (BOOL)becomeFirstResponder;
@end
@implementation LocationSearchField
- (BOOL)becomeFirstResponder
{
BOOL result = [super becomeFirstResponder];
if (result)
[self performSelector:@selector(selectText:) withObject:self afterDelay:0];
return result;
}
@end
@interface TabController () <NSToolbarDelegate, NSSearchFieldDelegate> @interface TabController () <NSToolbarDelegate, NSSearchFieldDelegate>
{ {
DeprecatedString m_title; DeprecatedString m_title;
@ -257,7 +275,7 @@ enum class IsHistoryNavigation {
attributes:highlight_attributes]; attributes:highlight_attributes];
} }
auto* location_search_field = (NSSearchField*)[self.location_toolbar_item view]; auto* location_search_field = (LocationSearchField*)[self.location_toolbar_item view];
[location_search_field setAttributedStringValue:attributed_url]; [location_search_field setAttributedStringValue:attributed_url];
} }
@ -450,7 +468,7 @@ enum class IsHistoryNavigation {
- (NSToolbarItem*)location_toolbar_item - (NSToolbarItem*)location_toolbar_item
{ {
if (!_location_toolbar_item) { if (!_location_toolbar_item) {
auto* location_search_field = [[NSSearchField alloc] init]; auto* location_search_field = [[LocationSearchField alloc] init];
[location_search_field setPlaceholderString:@"Enter web address"]; [location_search_field setPlaceholderString:@"Enter web address"];
[location_search_field setTextColor:[NSColor textColor]]; [location_search_field setTextColor:[NSColor textColor]];
[location_search_field setDelegate:self]; [location_search_field setDelegate:self];
@ -651,7 +669,7 @@ enum class IsHistoryNavigation {
- (void)controlTextDidEndEditing:(NSNotification*)notification - (void)controlTextDidEndEditing:(NSNotification*)notification
{ {
auto* location_search_field = (NSSearchField*)[self.location_toolbar_item view]; auto* location_search_field = (LocationSearchField*)[self.location_toolbar_item view];
auto url_string = Ladybird::ns_string_to_string([location_search_field stringValue]); auto url_string = Ladybird::ns_string_to_string([location_search_field stringValue]);
[self setLocationFieldText:url_string]; [self setLocationFieldText:url_string];