RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 05:52:46 +00:00
Code Issues Activity Actions

LibWeb: Pause keyframe animations during creation when necessary

Browse source
This commit is contained in:
Matthew Olsson 2024-02-25 10:03:25 -07:00 • committed by Sam Atkins
parent 2ee022dead
commit b235620315
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/CSS/Enums.json
View file

@ -50,6 +50,10 @@
"normal", "normal",
"reverse" "reverse"
], ],
"animation-play-state": [
"paused",
"running"
],
"appearance": [ "appearance": [
"auto", "auto",
"button", "button",

8
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -1059,6 +1059,12 @@ ErrorOr<void> StyleComputer::compute_cascaded_values(StyleProperties& style, DOM
direction = *direction_value; direction = *direction_value;
} }
CSS::AnimationPlayState play_state { CSS::AnimationPlayState::Running };
if (auto play_state_property = style.maybe_null_property(PropertyID::AnimationPlayState); play_state_property && play_state_property->is_identifier()) {
if (auto play_state_value = value_id_to_animation_play_state(play_state_property->to_identifier()); play_state_value.has_value())
play_state = *play_state_value;
}
Animations::TimingFunction timing_function = Animations::ease_timing_function; Animations::TimingFunction timing_function = Animations::ease_timing_function;
if (auto timing_property = style.maybe_null_property(PropertyID::AnimationTimingFunction); timing_property && timing_property->is_easing()) if (auto timing_property = style.maybe_null_property(PropertyID::AnimationTimingFunction); timing_property && timing_property->is_easing())
timing_function = Animations::TimingFunction::from_easing_style_value(timing_property->as_easing()); timing_function = Animations::TimingFunction::from_easing_style_value(timing_property->as_easing());
@ -1091,6 +1097,8 @@ ErrorOr<void> StyleComputer::compute_cascaded_values(StyleProperties& style, DOM
HTML::TemporaryExecutionContext context(m_document->relevant_settings_object()); HTML::TemporaryExecutionContext context(m_document->relevant_settings_object());
animation->play().release_value_but_fixme_should_propagate_errors(); animation->play().release_value_but_fixme_should_propagate_errors();
if (play_state == CSS::AnimationPlayState::Paused)
animation->pause().release_value_but_fixme_should_propagate_errors();
} }
} }