RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:47:34 +00:00
Code Issues Activity Actions

SystemMonitor: Prefer Core::File, poll ProcessStatisticsReader correctly

Browse source 
The signature of Core::ProcessStatisticsReader::get_all changed, and
instead of requiring a pointer to an open file, it now needs a bool to
indicate whether usernames should be polled or not. `m_proc_all` was
always converted to `false` in `RefPtr::operator bool()`, so we were
missing usernames for a long time.
This commit is contained in:
Ben Wiederhake 2023-05-13 14:52:21 +02:00 • committed by Andreas Kling
parent 07b6fb9104
commit b23a0b409d
2 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Applications/SystemMonitor/ProcessModel.h
View file

@ -244,7 +244,6 @@ private:
HashMap<int, NonnullRefPtr<Thread>> m_threads;
Vector<NonnullOwnPtr<Process>> m_processes;
Vector<NonnullOwnPtr<CpuInfo>> m_cpus;
RefPtr<Core::DeprecatedFile> m_proc_all;
GUI::Icon m_kernel_process_icon;
u64 m_total_time_scheduled { 0 };
u64 m_total_time_scheduled_kernel { 0 };