RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:18:11 +00:00
Code Issues Activity Actions

LibJS: Implement String.prototype.split

Browse source 
This adds a String.prototype.split implementation modelled after 
ECMA262 specification. 

Additionally, `Value::to_u32` was added as an implementation of
the standard `ToUint32` abstract operation.

There is a tiny kludge for when the separator is an empty string. 
Basic tests and visiting google.com prove that this is working.
This commit is contained in:
Marcin Gasperowicz 2021-01-09 21:52:47 +01:00 • committed by Andreas Kling
parent b53664a8ef
commit b24ce0b5ee
5 changed files with 140 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Value.h
View file

@ -36,6 +36,8 @@
// 2 ** 53 - 1
static constexpr double MAX_ARRAY_LIKE_INDEX = 9007199254740991.0;
// 2 ** 32 - 1
static constexpr double MAX_U32 = 4294967295.0;
namespace JS {
@ -241,6 +243,7 @@ public:
Function& as_function();
i32 as_i32() const;
u32 as_u32() const;
size_t as_size_t() const;
String to_string(GlobalObject&, bool legacy_null_to_empty_string = false) const;
@ -252,6 +255,7 @@ public:
BigInt* to_bigint(GlobalObject&) const;
double to_double(GlobalObject&) const;
i32 to_i32(GlobalObject&) const;
u32 to_u32(GlobalObject&) const;
size_t to_size_t(GlobalObject&) const;
size_t to_length(GlobalObject&) const;
size_t to_index(GlobalObject&) const;