RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:27:43 +00:00
Code Issues Activity Actions

LibJS: CallExpression shouldn't throw TypeError or non-constructor call

Browse source 
This unbreaks the entire test suite. :^)
This commit is contained in:
Andreas Kling 2020-04-19 14:50:27 +02:00
parent 90f8a7a36b
commit b251091a6a
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/AST.cpp
View file

@ -94,7 +94,7 @@ Value CallExpression::execute(Interpreter& interpreter) const
if (!callee.is_object() if (!callee.is_object()
|| !callee.as_object().is_function() || !callee.as_object().is_function()
|| (callee.as_object().is_native_function() && !static_cast<NativeFunction&>(callee.as_object()).has_constructor())) { || (is_new_expression() && (callee.as_object().is_native_function() && !static_cast<NativeFunction&>(callee.as_object()).has_constructor()))) {
String error_message; String error_message;
auto call_type = is_new_expression() ? "constructor" : "function"; auto call_type = is_new_expression() ? "constructor" : "function";
if (m_callee->is_identifier() || m_callee->is_member_expression()) { if (m_callee->is_identifier() || m_callee->is_member_expression()) {