diff --git a/Userland/Applications/PixelPaint/EllipseTool.cpp b/Userland/Applications/PixelPaint/EllipseTool.cpp index cf129ed86a..d70d3f3c23 100644 --- a/Userland/Applications/PixelPaint/EllipseTool.cpp +++ b/Userland/Applications/PixelPaint/EllipseTool.cpp @@ -8,8 +8,12 @@ #include "ImageEditor.h" #include "Layer.h" #include +#include +#include #include #include +#include +#include #include namespace PixelPaint { @@ -91,32 +95,51 @@ void EllipseTool::on_keydown(GUI::KeyEvent& event) } } -void EllipseTool::on_tool_button_contextmenu(GUI::ContextMenuEvent& event) +GUI::Widget* EllipseTool::get_properties_widget() { - if (!m_context_menu) { - m_context_menu = GUI::Menu::construct(); - m_context_menu->add_action(GUI::Action::create("Outline", [this](auto&) { - m_mode = Mode::Outline; - })); - m_context_menu->add_action(GUI::Action::create("Fill", [this](auto&) { - m_mode = Mode::Fill; - })); - m_context_menu->add_separator(); - m_thickness_actions.set_exclusive(true); - auto insert_action = [&](int size, bool checked = false) { - auto action = GUI::Action::create_checkable(String::number(size), [this, size](auto&) { - m_thickness = size; - }); - action->set_checked(checked); - m_thickness_actions.add_action(*action); - m_context_menu->add_action(move(action)); + if (!m_properties_widget) { + m_properties_widget = GUI::Widget::construct(); + m_properties_widget->set_layout(); + + auto& thickness_container = m_properties_widget->add(); + thickness_container.set_fixed_height(20); + thickness_container.set_layout(); + + auto& thickness_label = thickness_container.add("Thickness:"); + thickness_label.set_text_alignment(Gfx::TextAlignment::CenterLeft); + thickness_label.set_fixed_size(80, 20); + + auto& thickness_slider = thickness_container.add(); + thickness_slider.set_fixed_height(20); + thickness_slider.set_range(1, 10); + thickness_slider.set_value(m_thickness); + thickness_slider.on_change = [&](int value) { + m_thickness = value; }; - insert_action(1, true); - insert_action(2); - insert_action(3); - insert_action(4); + + auto& mode_container = m_properties_widget->add(); + mode_container.set_fixed_height(46); + mode_container.set_layout(); + auto& mode_label = mode_container.add("Mode:"); + mode_label.set_text_alignment(Gfx::TextAlignment::CenterLeft); + mode_label.set_fixed_size(80, 20); + + auto& mode_radio_container = mode_container.add(); + mode_radio_container.set_layout(); + auto& outline_mode_radio = mode_radio_container.add("Outline"); + auto& fill_mode_radio = mode_radio_container.add("Fill"); + + outline_mode_radio.on_checked = [&](bool) { + m_mode = Mode::Outline; + }; + fill_mode_radio.on_checked = [&](bool) { + m_mode = Mode::Fill; + }; + + outline_mode_radio.set_checked(true); } - m_context_menu->popup(event.screen_position()); + + return m_properties_widget.ptr(); } } diff --git a/Userland/Applications/PixelPaint/EllipseTool.h b/Userland/Applications/PixelPaint/EllipseTool.h index 63659c3442..7fa27685e1 100644 --- a/Userland/Applications/PixelPaint/EllipseTool.h +++ b/Userland/Applications/PixelPaint/EllipseTool.h @@ -20,9 +20,9 @@ public: virtual void on_mousedown(Layer&, GUI::MouseEvent& layer_event, GUI::MouseEvent& image_event) override; virtual void on_mousemove(Layer&, GUI::MouseEvent& layer_event, GUI::MouseEvent& image_event) override; virtual void on_mouseup(Layer&, GUI::MouseEvent& layer_event, GUI::MouseEvent& image_event) override; - virtual void on_tool_button_contextmenu(GUI::ContextMenuEvent&) override; virtual void on_second_paint(Layer const&, GUI::PaintEvent&) override; virtual void on_keydown(GUI::KeyEvent&) override; + virtual GUI::Widget* get_properties_widget() override; private: enum class Mode { @@ -32,12 +32,11 @@ private: void draw_using(GUI::Painter&, Gfx::IntRect const&); + RefPtr m_properties_widget; GUI::MouseButton m_drawing_button { GUI::MouseButton::None }; Gfx::IntPoint m_ellipse_start_position; Gfx::IntPoint m_ellipse_end_position; - RefPtr m_context_menu; int m_thickness { 1 }; - GUI::ActionGroup m_thickness_actions; Mode m_mode { Mode::Outline }; };