RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 11:12:45 +00:00
Code Issues Activity Actions

LibJS/Bytecode: Use proper this for receiver in get/set for super expr

Browse source 
Summary:
    Diff Tests:
        +14 ✅    -2 ❌    -12 📝
This commit is contained in:
Luke Wilde 2023-07-02 19:26:31 +01:00 • committed by Andreas Kling
parent b7d23162cc
commit b271d9a6bf
6 changed files with 323 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Bytecode/Pass/LoadElimination.cpp
View file

@ -122,9 +122,13 @@ static NonnullOwnPtr<BasicBlock> eliminate_loads(BasicBlock const& block, size_t
// These can trigger proxies, which call into user code
// So these are treated like calls
case GetByValue:
case GetByValueWithThis:
case GetById:
case GetByIdWithThis:
case PutByValue:
case PutByValueWithThis:
case PutById:
case PutByIdWithThis:
// Attribute accesses (`a.o` or `a[o]`) may result in calls to getters or setters
// or may trigger proxies
// So these are treated like calls