RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:07:45 +00:00
Code Issues Activity Actions

Browser: Better handle ports in user input to url conversion

Browse source 
Previously it was hard to enter a url with a port in browser:

"example.com:8080" -> Protocol not implemented: example.com

This patch makes an attempt at parsing the input as an url with http
first an validates if the url has a port.

"example.com:8080" -> "http://example.com:8080"
This commit is contained in:
networkException 2022-02-06 16:29:49 +01:00 • committed by Andreas Kling
parent e7b8498a4a
commit b28e861776
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Applications/Browser/Tab.cpp
View file

@ -38,20 +38,20 @@
namespace Browser { namespace Browser {
URL url_from_user_input(const String& input) URL url_from_user_input(String const& input)
{ {
String url_string = input;
if (input.starts_with("?") && !g_search_engine.is_empty()) if (input.starts_with("?") && !g_search_engine.is_empty())
url_string = g_search_engine.replace("{}", URL::percent_encode(input.substring_view(1))); return URL(g_search_engine.replace("{}", URL::percent_encode(input.substring_view(1))));
URL url = URL(url_string); URL url_with_http_schema = URL(String::formatted("http://{}", input));
if (url_with_http_schema.is_valid() && url_with_http_schema.port().has_value())
return url_with_http_schema;
URL url = URL(input);
if (url.is_valid()) if (url.is_valid())
return url; return url;
StringBuilder builder; return url_with_http_schema;
builder.append("http://");
builder.append(url_string);
return URL(builder.build());
} }
void Tab::start_download(const URL& url) void Tab::start_download(const URL& url)