mirror of
https://github.com/RGBCube/serenity
synced 2025-07-10 11:47:35 +00:00
LibGUI: Don't use Core::Object::add() to instantiate dialogs
Now that add() returns a WidgetType&, we can't rely on the parent of a GUI::Dialog to still keep it alive after exec() returns. This happens because exec() will call remove_from_parent() on itself before returning. And so we go back to the old idiom for creating a GUI::Dialog centered above a specific window. Just call GUI::Dialog::construct(), passing the "parent" window as the last parameter.
This commit is contained in:
parent
dfa69b82b4
commit
b29ff7b821
18 changed files with 43 additions and 43 deletions
|
@ -34,8 +34,8 @@
|
|||
|
||||
namespace GUI {
|
||||
|
||||
ColorPicker::ColorPicker(Color color, Core::Object* parent)
|
||||
: Dialog(parent)
|
||||
ColorPicker::ColorPicker(Color color, Window* parent_window)
|
||||
: Dialog(parent_window)
|
||||
, m_color(color)
|
||||
{
|
||||
set_title("Edit Color");
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue