RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:17:34 +00:00
Code Issues Activity Actions

LibWeb: Use TypedArrayBase::kind for pull into constructor lookup

Browse source
This commit is contained in:
Shannon Booth 2023-12-02 20:01:53 +13:00 • committed by Andreas Kling
parent a9a3dcd952
commit b2a0a41503
1 changed files with 10 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp
View file

@ -676,36 +676,20 @@ void readable_byte_stream_controller_pull_into(ReadableByteStreamController& con
// 4. If view has a [[TypedArrayName]] internal slot (i.e., it is not a DataView), // 4. If view has a [[TypedArrayName]] internal slot (i.e., it is not a DataView),
if (view.bufferable_object().has<JS::NonnullGCPtr<JS::TypedArrayBase>>()) { if (view.bufferable_object().has<JS::NonnullGCPtr<JS::TypedArrayBase>>()) {
auto const& typed_array = view.bufferable_object().get<JS::NonnullGCPtr<JS::TypedArrayBase>>(); auto const& typed_array = *view.bufferable_object().get<JS::NonnullGCPtr<JS::TypedArrayBase>>();
// 1. Set elementSize to the element size specified in the typed array constructors table for view.[[TypedArrayName]]. // 1. Set elementSize to the element size specified in the typed array constructors table for view.[[TypedArrayName]].
element_size = typed_array->element_size(); element_size = typed_array.element_size();
// 2. Set ctor to the constructor specified in the typed array constructors table for view.[[TypedArrayName]]. // 2. Set ctor to the constructor specified in the typed array constructors table for view.[[TypedArrayName]].
if (is<JS::Int16Array>(*typed_array)) switch (typed_array.kind()) {
ctor = realm.intrinsics().int16_array_constructor(); #define __JS_ENUMERATE(ClassName, snake_name, PrototypeName, ConstructorName, Type) \
else if (is<JS::Int32Array>(*typed_array)) case JS::TypedArrayBase::Kind::ClassName: \
ctor = realm.intrinsics().int32_array_constructor(); ctor = realm.intrinsics().snake_name##_constructor(); \
else if (is<JS::Int8Array>(*typed_array)) break;
ctor = realm.intrinsics().int8_array_constructor(); JS_ENUMERATE_TYPED_ARRAYS
else if (is<JS::Uint8Array>(*typed_array)) #undef __JS_ENUMERATE
ctor = realm.intrinsics().uint8_array_constructor(); }
else if (is<JS::Uint16Array>(*typed_array))
ctor = realm.intrinsics().uint16_array_constructor();
else if (is<JS::Uint32Array>(*typed_array))
ctor = realm.intrinsics().uint32_array_constructor();
else if (is<JS::Uint8ClampedArray>(*typed_array))
ctor = realm.intrinsics().uint8_clamped_array_constructor();
else if (is<JS::BigInt64Array>(*typed_array))
ctor = realm.intrinsics().big_int64_array_constructor();
else if (is<JS::BigUint64Array>(*typed_array))
ctor = realm.intrinsics().big_uint64_array_constructor();
else if (is<JS::Float32Array>(*typed_array))
ctor = realm.intrinsics().float32_array_constructor();
else if (is<JS::Float64Array>(*typed_array))
ctor = realm.intrinsics().float64_array_constructor();
else
VERIFY_NOT_REACHED();
} }
// 5. Let byteOffset be view.[[ByteOffset]]. // 5. Let byteOffset be view.[[ByteOffset]].