RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:07:34 +00:00
Code Issues Activity Actions

LibWeb: Resolve box shadow data for paintable boxes during layout

Browse source 
Step towards making the paintable tree independent of the layout tree.
This commit is contained in:
Aliaksandr Kalenik 2023-12-19 19:42:00 +01:00 • committed by Andreas Kling
parent f68c67bf3f
commit b2abd1dd05
4 changed files with 35 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -336,6 +336,33 @@ void LayoutState::resolve_border_radii()
}
}
void LayoutState::resolve_box_shadow_data()
{
for (auto& it : used_values_per_layout_node) {
auto& used_values = *it.value;
auto& node = const_cast<NodeWithStyle&>(used_values.node());
auto* paintable = node.paintable();
if (paintable && is<Painting::PaintableBox>(*paintable)) {
auto box_shadow_data = node.computed_values().box_shadow();
if (box_shadow_data.is_empty())
continue;
auto& paintable_box = static_cast<Painting::PaintableBox&>(*paintable);
Vector<Painting::ShadowData> resolved_box_shadow_data;
resolved_box_shadow_data.ensure_capacity(box_shadow_data.size());
for (auto const& layer : box_shadow_data) {
resolved_box_shadow_data.empend(
layer.color,
layer.offset_x.to_px(node),
layer.offset_y.to_px(node),
layer.blur_radius.to_px(node),
layer.spread_distance.to_px(node),
layer.placement == CSS::ShadowPlacement::Outer ? Painting::ShadowPlacement::Outer : Painting::ShadowPlacement::Inner);
}
paintable_box.set_box_shadow_data(move(resolved_box_shadow_data));
}
}
}
void LayoutState::commit(Box& root)
{
// Only the top-level LayoutState should ever be committed.
@ -432,6 +459,7 @@ void LayoutState::commit(Box& root)
}
resolve_border_radii();
resolve_box_shadow_data();
}
void LayoutState::UsedValues::set_node(NodeWithStyle& node, UsedValues const* containing_block_used_values)

1
Userland/Libraries/LibWeb/Layout/LayoutState.h
View file

@ -187,6 +187,7 @@ struct LayoutState {
private:
void resolve_relative_positions(Vector<Painting::PaintableWithLines&> const&);
void resolve_border_radii();
void resolve_box_shadow_data();
};
}