From b2e6ba8d7ff668e250410620b6b895bb8c756c82 Mon Sep 17 00:00:00 2001 From: Vitaly Dyachkov Date: Wed, 16 Feb 2022 18:00:45 +0100 Subject: [PATCH] LibGUI: Make a copy of source_rows before resizing it in sort_mapping() --- Userland/Libraries/LibGUI/SortingProxyModel.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibGUI/SortingProxyModel.cpp b/Userland/Libraries/LibGUI/SortingProxyModel.cpp index 9d25de8662..805a2a4fa6 100644 --- a/Userland/Libraries/LibGUI/SortingProxyModel.cpp +++ b/Userland/Libraries/LibGUI/SortingProxyModel.cpp @@ -163,6 +163,8 @@ ModelIndex SortingProxyModel::parent_index(ModelIndex const& proxy_index) const void SortingProxyModel::sort_mapping(Mapping& mapping, int column, SortOrder sort_order) { + auto old_source_rows = mapping.source_rows; + int row_count = source().row_count(mapping.source_parent); mapping.source_rows.resize(row_count); mapping.proxy_rows.resize(row_count); @@ -175,8 +177,6 @@ void SortingProxyModel::sort_mapping(Mapping& mapping, int column, SortOrder sor return; } - auto old_source_rows = mapping.source_rows; - for (int i = 0; i < row_count; ++i) mapping.source_rows[i] = i;