RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:58:11 +00:00
Code Issues Activity Actions

LibJS: Consider non-extensible objects in Reflect.setPrototypeOf()

Browse source
This commit is contained in:
Linus Groh 2020-06-02 12:39:02 +01:00 • committed by Andreas Kling
parent c1248a7fd8
commit b32761f2e0
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/ReflectObject.cpp
View file

@ -261,9 +261,7 @@ Value ReflectObject::set_prototype_of(Interpreter& interpreter)
Object* prototype = nullptr;
if (!prototype_value.is_null())
prototype = const_cast<Object*>(&prototype_value.as_object());
target->set_prototype(prototype);
// FIXME: Needs to return false for prototype chain cycles and non-extensible objects (don't have those yet).
return Value(true);
return Value(target->set_prototype(prototype));
}
}