RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:57:35 +00:00
Code Issues Activity Actions

LibWeb: Let canvas {fill,stroke}Style default to black, not transparent

Browse source 
I don't know if the original author simply missed this or thought the
default color of Gfx::Color is black, but this meant that drawing on a
canvas without explicitly setting a fillStyle or strokeStyle first would
be drawn in transparent color and therefore be invisible.

In the spec this is indicated by a small comment in the IDL definition:

    attribute ... strokeStyle; // (default black)
    attribute ... fillStyle; // (default black)

I'm starting to question whether Gfx::Color actually *should* have a
default constructor.
This commit is contained in:
Linus Groh 2021-12-27 14:16:17 +01:00 • committed by Andreas Kling
parent 6faaee2bc8
commit b32893eb54
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.h
View file

@ -81,8 +81,8 @@ private:
WeakPtr<HTMLCanvasElement> m_element;
Gfx::AffineTransform m_transform;
Gfx::Color m_fill_style;
Gfx::Color m_stroke_style;
Gfx::Color m_fill_style { Gfx::Color::Black };
Gfx::Color m_stroke_style { Gfx::Color::Black };
float m_line_width { 1 };
Gfx::Path m_path;