RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-22 18:32:06 +00:00
Code Issues Activity Actions

Terminal: Fix crash when scrolling contents while cursor is on first row.

Browse source
This commit is contained in:
Andreas Kling 2019-01-23 07:45:23 +01:00
parent cfa197f821
commit b33e367f33
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Terminal/Terminal.cpp
View file

@ -418,6 +418,8 @@ Rect Terminal::row_rect(word row)
inline Terminal::Attribute& Terminal::attribute_at(word row, word column) inline Terminal::Attribute& Terminal::attribute_at(word row, word column)
{ {
ASSERT(row < m_rows);
ASSERT(column < m_columns);
return m_attributes[(row * m_columns) + column]; return m_attributes[(row * m_columns) + column];
} }
@ -440,7 +442,7 @@ void Terminal::paint()
scanlines_to_copy * m_pixel_width scanlines_to_copy * m_pixel_width
); );
m_need_full_invalidation = true; m_need_full_invalidation = true;
attribute_at(m_cursor_row - m_rows_to_scroll_backing_store, m_cursor_column).dirty = true; attribute_at(max(0, m_cursor_row - m_rows_to_scroll_backing_store), m_cursor_column).dirty = true;
} }
m_rows_to_scroll_backing_store = 0; m_rows_to_scroll_backing_store = 0;
#endif #endif