RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:57:35 +00:00
Code Issues Activity Actions

LibWeb: Fix buttons with TextNode label

Browse source 
Fixes #20472.
This commit is contained in:
Andi Gallo 2023-08-11 03:19:31 +00:00 • committed by Andreas Kling
parent afb19a2cff
commit b34b80104f
9 changed files with 94 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

48
Tests/LibWeb/Layout/expected/block-and-inline/button-should-have-vertically-aligned-content.txt
View file

@ -5,41 +5,39 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
frag 0 from BlockContainer start: 0, length: 0, rect: [22,19 48.6875x178]
TextNode <#text>
BlockContainer <button.button.border-black> at (22,19) content-size 48.6875x178 inline-block [BFC] children: not-inline
BlockContainer <(anonymous)> at (22,19) content-size 48.6875x0 children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (22,19) content-size 48.6875x0 children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (22,19) content-size 48.6875x0 children: inline
TextNode <#text>
TableWrapper <(anonymous)> at (22,19) content-size 48.6875x178 [BFC] children: not-inline
BlockContainer <(anonymous)> at (22,19) content-size 48.6875x178 table-box [TFC] children: not-inline
Box <(anonymous)> at (22,19) content-size 48.6875x178 table-row children: not-inline
BlockContainer <(anonymous)> at (22,29.265625) content-size 48.6875x157.46875 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> at (22,29.265625) content-size 48.6875x157.46875 inline-block [BFC] children: not-inline
BlockContainer <div.border-black> at (32,39.265625) content-size 28.6875x17.46875 children: inline
line 0 width: 28.6875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 3, rect: [32,39.265625 28.6875x17.46875]
"one"
TextNode <#text>
BlockContainer <div.border-black> at (32,76.734375) content-size 28.6875x100 children: inline
line 0 width: 28.4375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 3, rect: [32,76.734375 28.4375x17.46875]
"two"
TextNode <#text>
BlockContainer <(anonymous)> at (22,29.265625) content-size 48.6875x0 children: inline
TextNode <#text>
BlockContainer <div.border-black> at (32,39.265625) content-size 28.6875x17.46875 children: inline
line 0 width: 28.6875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 3, rect: [32,39.265625 28.6875x17.46875]
"one"
TextNode <#text>
BlockContainer <(anonymous)> at (22,66.734375) content-size 48.6875x0 children: inline
TextNode <#text>
BlockContainer <div.border-black> at (32,76.734375) content-size 28.6875x100 children: inline
line 0 width: 28.4375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 3, rect: [32,76.734375 28.4375x17.46875]
"two"
TextNode <#text>
BlockContainer <(anonymous)> at (22,186.734375) content-size 48.6875x0 children: inline
TextNode <#text>
PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x200]
PaintableWithLines (BlockContainer<BUTTON>.button.border-black) [8,8 76.6875x200]
PaintableWithLines (BlockContainer(anonymous)) [22,19 48.6875x0]
PaintableWithLines (BlockContainer(anonymous)) [22,19 48.6875x0]
PaintableWithLines (BlockContainer(anonymous)) [22,19 48.6875x0]
PaintableWithLines (TableWrapper(anonymous)) [22,19 48.6875x178]
PaintableWithLines (BlockContainer(anonymous)) [22,19 48.6875x178]
PaintableBox (Box(anonymous)) [22,19 48.6875x178]
PaintableWithLines (BlockContainer(anonymous)) [22,19 48.6875x178]
PaintableWithLines (BlockContainer(anonymous)) [22,29.265625 48.6875x157.46875]
PaintableWithLines (BlockContainer<DIV>.border-black) [22,29.265625 48.6875x37.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.border-black) [22,66.734375 48.6875x120]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [22,29.265625 48.6875x0]
PaintableWithLines (BlockContainer<DIV>.border-black) [22,29.265625 48.6875x37.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [22,66.734375 48.6875x0]
PaintableWithLines (BlockContainer<DIV>.border-black) [22,66.734375 48.6875x120]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [22,186.734375 48.6875x0]

26
Tests/LibWeb/Layout/expected/block-and-inline/button-with-multiple-words-text-node-label.txt Normal file
View file

@ -0,0 +1,26 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x21.46875 children: inline
line 0 width: 59.921875, height: 21.46875, bottom: 21.46875, baseline: 19.46875
frag 0 from BlockContainer start: 0, length: 0, rect: [13,10 49.921875x17.46875]
BlockContainer <button> at (13,10) content-size 49.921875x17.46875 inline-block [BFC] children: inline
line 0 width: 49.921875, height: 17.46875, bottom: 17.46875, baseline: 17.46875
frag 0 from TableWrapper start: 0, length: 0, rect: [13,10 49.921875x17.46875]
TableWrapper <(anonymous)> at (13,10) content-size 49.921875x17.46875 [BFC] children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 49.921875x17.46875 table-box [TFC] children: not-inline
Box <(anonymous)> at (13,10) content-size 49.921875x17.46875 table-row children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 49.921875x17.46875 table-cell [BFC] children: inline
line 0 width: 49.921875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [13,10 49.921875x17.46875]
"A B C"
TextNode <#text>
PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x21.46875]
PaintableWithLines (BlockContainer<BUTTON>) [8,8 59.921875x21.46875]
PaintableWithLines (TableWrapper(anonymous)) [13,10 49.921875x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [13,10 49.921875x17.46875]
PaintableBox (Box(anonymous)) [13,10 49.921875x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [13,10 49.921875x17.46875]
TextPaintable (TextNode<#text>)

26
Tests/LibWeb/Layout/expected/block-and-inline/button-with-text-node-label.txt Normal file
View file

@ -0,0 +1,26 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x21.46875 children: inline
line 0 width: 47.21875, height: 21.46875, bottom: 21.46875, baseline: 19.46875
frag 0 from BlockContainer start: 0, length: 0, rect: [13,10 37.21875x17.46875]
BlockContainer <button> at (13,10) content-size 37.21875x17.46875 inline-block [BFC] children: inline
line 0 width: 37.21875, height: 17.46875, bottom: 17.46875, baseline: 17.46875
frag 0 from TableWrapper start: 0, length: 0, rect: [13,10 37.21875x17.46875]
TableWrapper <(anonymous)> at (13,10) content-size 37.21875x17.46875 [BFC] children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 37.21875x17.46875 table-box [TFC] children: not-inline
Box <(anonymous)> at (13,10) content-size 37.21875x17.46875 table-row children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 37.21875x17.46875 table-cell [BFC] children: inline
line 0 width: 37.21875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [13,10 37.21875x17.46875]
"Test"
TextNode <#text>
PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x21.46875]
PaintableWithLines (BlockContainer<BUTTON>) [8,8 47.21875x21.46875]
PaintableWithLines (TableWrapper(anonymous)) [13,10 37.21875x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [13,10 37.21875x17.46875]
PaintableBox (Box(anonymous)) [13,10 37.21875x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [13,10 37.21875x17.46875]
TextPaintable (TextNode<#text>)