diff --git a/Userland/Libraries/LibCore/DateTime.cpp b/Userland/Libraries/LibCore/DateTime.cpp index dce43d57b5..3a7fdfe345 100644 --- a/Userland/Libraries/LibCore/DateTime.cpp +++ b/Userland/Libraries/LibCore/DateTime.cpp @@ -83,7 +83,7 @@ void DateTime::set_time(int year, int month, int day, int hour, int minute, int m_second = tm.tm_sec; } -String DateTime::to_string(const String& format) const +String DateTime::to_string(StringView format) const { const char wday_short_names[7][4] = { "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat" @@ -261,7 +261,7 @@ String DateTime::to_string(const String& format) const return builder.build(); } -Optional DateTime::parse(const String& format, const String& string) +Optional DateTime::parse(StringView format, const String& string) { unsigned format_pos = 0; unsigned string_pos = 0; diff --git a/Userland/Libraries/LibCore/DateTime.h b/Userland/Libraries/LibCore/DateTime.h index 30ac5227af..41d8a1ad72 100644 --- a/Userland/Libraries/LibCore/DateTime.h +++ b/Userland/Libraries/LibCore/DateTime.h @@ -7,6 +7,7 @@ #pragma once #include +#include #include #include @@ -30,12 +31,12 @@ public: bool is_leap_year() const; void set_time(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0); - String to_string(const String& format = "%Y-%m-%d %H:%M:%S") const; + String to_string(StringView format = "%Y-%m-%d %H:%M:%S"sv) const; static DateTime create(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0); static DateTime now(); static DateTime from_timestamp(time_t); - static Optional parse(const String& format, const String& string); + static Optional parse(StringView format, const String& string); bool operator<(const DateTime& other) const { return m_timestamp < other.m_timestamp; }