RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:27:36 +00:00
Code Issues Activity Actions

LibWeb: Determine origin while populating navigation params from srcdoc

Browse source 
Address the FIXMEs by implementing the missing parts of the procedure
from the specification.
This commit is contained in:
Aliaksandr Kalenik 2023-09-13 22:38:28 +02:00 • committed by Andreas Kling
parent 7ad2dd2693
commit b398d6a35c
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -383,18 +383,19 @@ static WebIDL::ExceptionOr<NavigationParams> create_navigation_params_from_a_src
TRY_OR_THROW_OOM(vm, response->header_list()->append(move(header))); TRY_OR_THROW_OOM(vm, response->header_list()->append(move(header)));
response->set_body(TRY(Fetch::Infrastructure::byte_sequence_as_body(realm, document_resource.get<String>().bytes()))); response->set_body(TRY(Fetch::Infrastructure::byte_sequence_as_body(realm, document_resource.get<String>().bytes())));
// FIXME: 3. Let responseOrigin be the result of determining the origin given response's URL, targetSnapshotParams's sandboxing flags, null, and entry's document state's origin. // 3. Let responseOrigin be the result of determining the origin given response's URL, targetSnapshotParams's sandboxing flags, null, and entry's document state's origin.
auto response_origin = determine_the_origin(*response->url(), SandboxingFlagSet {}, {}, entry->document_state->origin());
// 4. Let coop be a new cross-origin opener policy. // 4. Let coop be a new cross-origin opener policy.
CrossOriginOpenerPolicy coop; CrossOriginOpenerPolicy coop;
// 5. Let coopEnforcementResult be a new cross-origin opener policy enforcement result with // 5. Let coopEnforcementResult be a new cross-origin opener policy enforcement result with
// url: response's URL // url: response's URL
// FIXME: origin: responseOrigin // origin: responseOrigin
// cross-origin opener policy: coop // cross-origin opener policy: coop
CrossOriginOpenerPolicyEnforcementResult coop_enforcement_result { CrossOriginOpenerPolicyEnforcementResult coop_enforcement_result {
.url = *response->url(), .url = *response->url(),
.origin = Origin {}, .origin = response_origin,
.cross_origin_opener_policy = coop .cross_origin_opener_policy = coop
}; };
@ -404,7 +405,7 @@ static WebIDL::ExceptionOr<NavigationParams> create_navigation_params_from_a_src
// id: navigationId // id: navigationId
// request: null // request: null
// response: response // response: response
// FIXME: origin: responseOrigin // origin: responseOrigin
// FIXME: policy container: policyContainer // FIXME: policy container: policyContainer
// FIXME: final sandboxing flag set: targetSnapshotParams's sandboxing flags // FIXME: final sandboxing flag set: targetSnapshotParams's sandboxing flags
// cross-origin opener policy: coop // cross-origin opener policy: coop
@ -418,7 +419,7 @@ static WebIDL::ExceptionOr<NavigationParams> create_navigation_params_from_a_src
.id = navigation_id, .id = navigation_id,
.request = {}, .request = {},
.response = *response, .response = *response,
.origin = Origin {}, .origin = move(response_origin),
.policy_container = PolicyContainer {}, .policy_container = PolicyContainer {},
.final_sandboxing_flag_set = SandboxingFlagSet {}, .final_sandboxing_flag_set = SandboxingFlagSet {},
.cross_origin_opener_policy = move(coop), .cross_origin_opener_policy = move(coop),