RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00
Code Issues Activity Actions

LibWeb: Add FIXME whining to debug log if layout produces negative sizes

Browse source 
Negative width/height sizes are not allowed in CSS, so if our layout
algorithm resolves something to a negative size, we have boogs.

Instead of crashing or rendering something very wrong, we now clamp the
values to 0 and whine on the debug log so that someone can go and figure
out how we got the negative values in the first place. :^)
This commit is contained in:
Andreas Kling 2023-03-25 17:33:22 +01:00
parent 4bf10674fa
commit b3b9ac6201
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -326,12 +326,22 @@ void LayoutState::UsedValues::set_node(NodeWithStyleAndBoxModelMetrics& node, Us
void LayoutState::UsedValues::set_content_width(CSSPixels width) void LayoutState::UsedValues::set_content_width(CSSPixels width)
{ {
if (width < 0) {
// Negative heights are not allowed in CSS. We have a bug somewhere! Clamp to 0 to avoid doing too much damage.
dbgln("FIXME: Layout calculated a negative width for {}: {}", m_node->debug_description(), width);
width = 0;
}
m_content_width = width; m_content_width = width;
m_has_definite_width = true; m_has_definite_width = true;
} }
void LayoutState::UsedValues::set_content_height(CSSPixels height) void LayoutState::UsedValues::set_content_height(CSSPixels height)
{ {
if (height < 0) {
// Negative heights are not allowed in CSS. We have a bug somewhere! Clamp to 0 to avoid doing too much damage.
dbgln("FIXME: Layout calculated a negative height for {}: {}", m_node->debug_description(), height);
height = 0;
}
m_content_height = height; m_content_height = height;
m_has_definite_height = true; m_has_definite_height = true;
} }