diff --git a/Userland/Libraries/LibAudio/ClientConnection.h b/Userland/Libraries/LibAudio/ClientConnection.h index ef0f8084d8..183710f660 100644 --- a/Userland/Libraries/LibAudio/ClientConnection.h +++ b/Userland/Libraries/LibAudio/ClientConnection.h @@ -19,8 +19,6 @@ class ClientConnection final , public AudioClientEndpoint { C_OBJECT(ClientConnection) public: - ClientConnection(); - void enqueue(Buffer const&); bool try_enqueue(Buffer const&); void async_enqueue(Buffer const&); @@ -31,6 +29,8 @@ public: Function on_client_volume_change; private: + ClientConnection(); + virtual void finished_playing_buffer(i32) override; virtual void muted_state_changed(bool) override; virtual void main_mix_volume_changed(double) override; diff --git a/Userland/Libraries/LibChess/UCIEndpoint.h b/Userland/Libraries/LibChess/UCIEndpoint.h index 8207525028..430d8edcfc 100644 --- a/Userland/Libraries/LibChess/UCIEndpoint.h +++ b/Userland/Libraries/LibChess/UCIEndpoint.h @@ -18,9 +18,6 @@ class Endpoint : public Core::Object { public: virtual ~Endpoint() override { } - Endpoint() { } - Endpoint(NonnullRefPtr in, NonnullRefPtr out); - virtual void handle_uci() { } virtual void handle_debug(const DebugCommand&) { } virtual void handle_isready() { } @@ -48,6 +45,10 @@ public: } void set_out(RefPtr out) { m_out = out; } +protected: + Endpoint() { } + Endpoint(NonnullRefPtr in, NonnullRefPtr out); + private: void set_in_notifier(); NonnullOwnPtr read_command(); diff --git a/Userland/Libraries/LibCore/EventLoop.cpp b/Userland/Libraries/LibCore/EventLoop.cpp index d6a5a95ac6..1f99d51fef 100644 --- a/Userland/Libraries/LibCore/EventLoop.cpp +++ b/Userland/Libraries/LibCore/EventLoop.cpp @@ -125,7 +125,7 @@ pid_t EventLoop::s_pid; class InspectorServerConnection : public Object { C_OBJECT(InspectorServerConnection) -public: +private: explicit InspectorServerConnection(RefPtr socket) : m_socket(move(socket)) , m_client_id(s_id_allocator->allocate()) @@ -162,6 +162,7 @@ public: inspected_object->decrement_inspector_count({}); } +public: void send_response(const JsonObject& response) { auto serialized = response.to_string(); diff --git a/Userland/Libraries/LibCore/Promise.h b/Userland/Libraries/LibCore/Promise.h index d6622cfc48..a419ef37fa 100644 --- a/Userland/Libraries/LibCore/Promise.h +++ b/Userland/Libraries/LibCore/Promise.h @@ -14,9 +14,6 @@ template class Promise : public Object { C_OBJECT(Promise); -private: - Optional m_pending; - public: Function on_resolved; @@ -51,5 +48,10 @@ public: }; return new_promise; } + +private: + Promise() = default; + + Optional m_pending; }; } diff --git a/Userland/Libraries/LibGUI/AbstractScrollableWidget.h b/Userland/Libraries/LibGUI/AbstractScrollableWidget.h index b18eca59bf..daea99ee97 100644 --- a/Userland/Libraries/LibGUI/AbstractScrollableWidget.h +++ b/Userland/Libraries/LibGUI/AbstractScrollableWidget.h @@ -81,7 +81,7 @@ private: class AbstractScrollableWidgetScrollbar final : public Scrollbar { C_OBJECT(AbstractScrollableWidgetScrollbar); - protected: + private: explicit AbstractScrollableWidgetScrollbar(AbstractScrollableWidget& owner, Gfx::Orientation orientation) : Scrollbar(orientation) , m_owner(owner) @@ -93,7 +93,6 @@ private: m_owner.handle_wheel_event(event, *this); } - private: AbstractScrollableWidget& m_owner; }; friend class ScrollableWidgetScrollbar; diff --git a/Userland/Libraries/LibGUI/BoxLayout.h b/Userland/Libraries/LibGUI/BoxLayout.h index 9faba28e0e..433c5bf4bb 100644 --- a/Userland/Libraries/LibGUI/BoxLayout.h +++ b/Userland/Libraries/LibGUI/BoxLayout.h @@ -36,7 +36,7 @@ private: class VerticalBoxLayout final : public BoxLayout { C_OBJECT(VerticalBoxLayout); -public: +private: explicit VerticalBoxLayout() : BoxLayout(Gfx::Orientation::Vertical) { @@ -47,7 +47,7 @@ public: class HorizontalBoxLayout final : public BoxLayout { C_OBJECT(HorizontalBoxLayout); -public: +private: explicit HorizontalBoxLayout() : BoxLayout(Gfx::Orientation::Horizontal) { diff --git a/Userland/Libraries/LibGUI/Calendar.h b/Userland/Libraries/LibGUI/Calendar.h index 28db8c7d16..017a1182b2 100644 --- a/Userland/Libraries/LibGUI/Calendar.h +++ b/Userland/Libraries/LibGUI/Calendar.h @@ -30,9 +30,6 @@ public: YearOnly }; - Calendar(Core::DateTime date_time = Core::DateTime::now(), Mode mode = Month); - virtual ~Calendar() override; - void set_selected_date(Core::DateTime date_time) { m_selected_date = date_time; } Core::DateTime selected_date() const { return m_selected_date; } @@ -75,6 +72,9 @@ public: Function on_month_click; private: + Calendar(Core::DateTime date_time = Core::DateTime::now(), Mode mode = Month); + virtual ~Calendar() override; + virtual void resize_event(GUI::ResizeEvent&) override; virtual void paint_event(GUI::PaintEvent&) override; virtual void mousemove_event(GUI::MouseEvent&) override; diff --git a/Userland/Libraries/LibGUI/ColorPicker.cpp b/Userland/Libraries/LibGUI/ColorPicker.cpp index f2e602f837..2d5103ab00 100644 --- a/Userland/Libraries/LibGUI/ColorPicker.cpp +++ b/Userland/Libraries/LibGUI/ColorPicker.cpp @@ -129,11 +129,6 @@ private: class ColorSelectOverlay final : public Widget { C_OBJECT(ColorSelectOverlay) public: - ColorSelectOverlay() - { - set_override_cursor(Gfx::StandardCursor::Eyedropper); - } - Optional exec() { m_event_loop = make(); @@ -156,6 +151,11 @@ public: Function on_color_changed; private: + ColorSelectOverlay() + { + set_override_cursor(Gfx::StandardCursor::Eyedropper); + } + virtual void mousedown_event(GUI::MouseEvent&) override { m_event_loop->quit(1); } virtual void mousemove_event(GUI::MouseEvent&) override { diff --git a/Userland/Libraries/LibGUI/TextBox.h b/Userland/Libraries/LibGUI/TextBox.h index 13e002e628..ccc53722c1 100644 --- a/Userland/Libraries/LibGUI/TextBox.h +++ b/Userland/Libraries/LibGUI/TextBox.h @@ -14,7 +14,6 @@ namespace GUI { class TextBox : public TextEditor { C_OBJECT(TextBox) public: - TextBox(); virtual ~TextBox() override; Function on_up_pressed; @@ -23,6 +22,9 @@ public: void set_history_enabled(bool enabled) { m_history_enabled = enabled; } void add_current_text_to_history(); +protected: + TextBox(); + private: virtual void keydown_event(GUI::KeyEvent&) override; @@ -39,20 +41,21 @@ private: class PasswordBox : public TextBox { C_OBJECT(PasswordBox) -public: +private: PasswordBox(); }; class UrlBox : public TextBox { C_OBJECT(UrlBox) public: - UrlBox(); virtual ~UrlBox() override; void set_focus_transition(bool focus_transition) { m_focus_transition = focus_transition; } bool is_focus_transition() const { return m_focus_transition; } private: + UrlBox(); + virtual void mousedown_event(GUI::MouseEvent&) override; virtual void focusout_event(GUI::FocusEvent&) override; diff --git a/Userland/Libraries/LibGUI/WindowManagerServerConnection.h b/Userland/Libraries/LibGUI/WindowManagerServerConnection.h index b91d4e9005..053c901564 100644 --- a/Userland/Libraries/LibGUI/WindowManagerServerConnection.h +++ b/Userland/Libraries/LibGUI/WindowManagerServerConnection.h @@ -18,14 +18,14 @@ class WindowManagerServerConnection final , public WindowManagerClientEndpoint { C_OBJECT(WindowManagerServerConnection) public: + static WindowManagerServerConnection& the(); + +private: WindowManagerServerConnection() : IPC::ServerConnection(*this, "/tmp/portal/wm") { } - static WindowManagerServerConnection& the(); - -private: virtual void window_removed(i32, i32, i32) override; virtual void window_state_changed(i32, i32, i32, i32, i32, u32, u32, bool, bool, bool, bool, i32, String const&, Gfx::IntRect const&, Optional const&) override; virtual void window_icon_bitmap_changed(i32, i32, i32, Gfx::ShareableBitmap const&) override; diff --git a/Userland/Libraries/LibGemini/GeminiJob.h b/Userland/Libraries/LibGemini/GeminiJob.h index 7cad08473d..ec554ee294 100644 --- a/Userland/Libraries/LibGemini/GeminiJob.h +++ b/Userland/Libraries/LibGemini/GeminiJob.h @@ -17,12 +17,6 @@ namespace Gemini { class GeminiJob final : public Job { C_OBJECT(GeminiJob) public: - explicit GeminiJob(const GeminiRequest& request, OutputStream& output_stream, const Vector* override_certificates = nullptr) - : Job(request, output_stream) - , m_override_ca_certificates(override_certificates) - { - } - virtual ~GeminiJob() override { } @@ -50,6 +44,12 @@ protected: virtual void read_while_data_available(Function) override; private: + explicit GeminiJob(const GeminiRequest& request, OutputStream& output_stream, const Vector* override_certificates = nullptr) + : Job(request, output_stream) + , m_override_ca_certificates(override_certificates) + { + } + RefPtr m_socket; const Vector* m_override_ca_certificates { nullptr }; }; diff --git a/Userland/Libraries/LibHTTP/HttpJob.h b/Userland/Libraries/LibHTTP/HttpJob.h index 08acf9ef79..57495f8c91 100644 --- a/Userland/Libraries/LibHTTP/HttpJob.h +++ b/Userland/Libraries/LibHTTP/HttpJob.h @@ -18,11 +18,6 @@ namespace HTTP { class HttpJob final : public Job { C_OBJECT(HttpJob) public: - explicit HttpJob(const HttpRequest& request, OutputStream& output_stream) - : Job(request, output_stream) - { - } - virtual ~HttpJob() override { } @@ -46,6 +41,11 @@ protected: virtual bool is_established() const override { return true; } private: + explicit HttpJob(const HttpRequest& request, OutputStream& output_stream) + : Job(request, output_stream) + { + } + RefPtr m_socket; }; diff --git a/Userland/Libraries/LibHTTP/HttpsJob.h b/Userland/Libraries/LibHTTP/HttpsJob.h index 149861727a..b53cf94a7d 100644 --- a/Userland/Libraries/LibHTTP/HttpsJob.h +++ b/Userland/Libraries/LibHTTP/HttpsJob.h @@ -18,12 +18,6 @@ namespace HTTP { class HttpsJob final : public Job { C_OBJECT(HttpsJob) public: - explicit HttpsJob(const HttpRequest& request, OutputStream& output_stream, const Vector* override_certs = nullptr) - : Job(request, output_stream) - , m_override_ca_certificates(override_certs) - { - } - virtual ~HttpsJob() override { } @@ -51,6 +45,12 @@ protected: virtual void read_while_data_available(Function) override; private: + explicit HttpsJob(const HttpRequest& request, OutputStream& output_stream, const Vector* override_certs = nullptr) + : Job(request, output_stream) + , m_override_ca_certificates(override_certs) + { + } + RefPtr m_socket; const Vector* m_override_ca_certificates { nullptr }; }; diff --git a/Userland/Libraries/LibSQL/Database.h b/Userland/Libraries/LibSQL/Database.h index b3bfc0d3af..ae562941bc 100644 --- a/Userland/Libraries/LibSQL/Database.h +++ b/Userland/Libraries/LibSQL/Database.h @@ -24,7 +24,6 @@ class Database : public Core::Object { C_OBJECT(Database); public: - explicit Database(String); ~Database() override = default; void commit() { m_heap->flush(); } @@ -43,6 +42,8 @@ public: bool update(Row&); private: + explicit Database(String); + NonnullRefPtr m_heap; Serializer m_serializer; RefPtr m_schemas; diff --git a/Userland/Libraries/LibSQL/Heap.h b/Userland/Libraries/LibSQL/Heap.h index 4f83928795..caef7e8702 100644 --- a/Userland/Libraries/LibSQL/Heap.h +++ b/Userland/Libraries/LibSQL/Heap.h @@ -32,7 +32,6 @@ class Heap : public Core::Object { C_OBJECT(Heap); public: - explicit Heap(String); virtual ~Heap() override { flush(); } u32 size() const { return m_end_of_file; } @@ -93,6 +92,8 @@ public: void flush(); private: + explicit Heap(String); + bool seek_block(u32); void read_zero_block(); void initialize_zero_block(); diff --git a/Userland/Libraries/LibSQL/Meta.h b/Userland/Libraries/LibSQL/Meta.h index ec8cd367f7..29c89e6f98 100644 --- a/Userland/Libraries/LibSQL/Meta.h +++ b/Userland/Libraries/LibSQL/Meta.h @@ -96,10 +96,11 @@ class KeyPartDef : public ColumnDef { C_OBJECT(KeyPartDef); public: - KeyPartDef(IndexDef*, String, SQLType, Order = Order::Ascending); Order sort_order() const { return m_sort_order; } private: + KeyPartDef(IndexDef*, String, SQLType, Order = Order::Ascending); + Order m_sort_order { Order::Ascending }; }; diff --git a/Userland/Libraries/LibVT/TerminalWidget.h b/Userland/Libraries/LibVT/TerminalWidget.h index d1e5c9680f..3eaeb1f116 100644 --- a/Userland/Libraries/LibVT/TerminalWidget.h +++ b/Userland/Libraries/LibVT/TerminalWidget.h @@ -27,7 +27,6 @@ class TerminalWidget final C_OBJECT(TerminalWidget); public: - TerminalWidget(int ptm_fd, bool automatic_size_policy); virtual ~TerminalWidget() override; void set_pty_master_fd(int fd); @@ -95,6 +94,8 @@ public: void set_color_scheme(const StringView&); private: + TerminalWidget(int ptm_fd, bool automatic_size_policy); + // ^GUI::Widget virtual void event(Core::Event&) override; virtual void paint_event(GUI::PaintEvent&) override; diff --git a/Userland/Libraries/LibWebSocket/Impl/TCPWebSocketConnectionImpl.h b/Userland/Libraries/LibWebSocket/Impl/TCPWebSocketConnectionImpl.h index 3c686e194c..1ece3f8bef 100644 --- a/Userland/Libraries/LibWebSocket/Impl/TCPWebSocketConnectionImpl.h +++ b/Userland/Libraries/LibWebSocket/Impl/TCPWebSocketConnectionImpl.h @@ -22,7 +22,6 @@ class TCPWebSocketConnectionImpl final : public AbstractWebSocketImpl { public: virtual ~TCPWebSocketConnectionImpl() override; - explicit TCPWebSocketConnectionImpl(Core::Object* parent = nullptr); virtual void connect(ConnectionInfo const& connection) override; @@ -39,6 +38,8 @@ public: virtual void discard_connection() override; private: + explicit TCPWebSocketConnectionImpl(Core::Object* parent = nullptr); + RefPtr m_notifier; RefPtr m_socket; }; diff --git a/Userland/Libraries/LibWebSocket/Impl/TLSv12WebSocketConnectionImpl.h b/Userland/Libraries/LibWebSocket/Impl/TLSv12WebSocketConnectionImpl.h index fecdd4d38f..6cfe8b1592 100644 --- a/Userland/Libraries/LibWebSocket/Impl/TLSv12WebSocketConnectionImpl.h +++ b/Userland/Libraries/LibWebSocket/Impl/TLSv12WebSocketConnectionImpl.h @@ -21,7 +21,6 @@ class TLSv12WebSocketConnectionImpl final : public AbstractWebSocketImpl { public: virtual ~TLSv12WebSocketConnectionImpl() override; - explicit TLSv12WebSocketConnectionImpl(Core::Object* parent = nullptr); void connect(ConnectionInfo const& connection) override; @@ -38,6 +37,8 @@ public: virtual void discard_connection() override; private: + explicit TLSv12WebSocketConnectionImpl(Core::Object* parent = nullptr); + RefPtr m_socket; };