RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:47:45 +00:00
Code Issues Activity Actions

Kernel: Better handling of allocation failure in profiling

Browse source 
If we can't allocate a PerformanceEventBuffer to store the profiling
events, we now fail sys$profiling_enable() and sys$perf_event()
with ENOMEM instead of carrying on with a broken buffer.
This commit is contained in:
Andreas Kling 2021-03-02 16:55:54 +01:00
parent e7ef729db3
commit b425c2602c
6 changed files with 26 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Kernel/PerformanceEventBuffer.h
View file

@ -58,7 +58,7 @@ struct [[gnu::packed]] PerformanceEvent {
class PerformanceEventBuffer {
public:
PerformanceEventBuffer();
static OwnPtr<PerformanceEventBuffer> try_create_with_size(size_t buffer_size);
KResult append(int type, FlatPtr arg1, FlatPtr arg2);
KResult append_with_eip_and_ebp(u32 eip, u32 ebp, int type, FlatPtr arg1, FlatPtr arg2);
@ -68,12 +68,7 @@ public:
m_count = 0;
}
size_t capacity() const
{
if (!m_buffer)
return 0;
return m_buffer->size() / sizeof(PerformanceEvent);
}
size_t capacity() const { return m_buffer->size() / sizeof(PerformanceEvent); }
size_t count() const { return m_count; }
const PerformanceEvent& at(size_t index) const
{
@ -84,10 +79,12 @@ public:
bool to_json(KBufferBuilder&, ProcessID, const String& executable_path) const;
private:
explicit PerformanceEventBuffer(NonnullOwnPtr<KBuffer>);
PerformanceEvent& at(size_t index);
size_t m_count { 0 };
OwnPtr<KBuffer> m_buffer;
NonnullOwnPtr<KBuffer> m_buffer;
};
}