RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:37:45 +00:00
Code Issues Activity Actions

LibPDF: Don't use unsanitized values in error messages

Browse source 
Previously, constructing error messages with unsanitized input could
fail because error message strings must be UTF-8.
This commit is contained in:
Tim Ledbetter 2023-10-25 23:45:56 +01:00 • committed by Andreas Kling
parent f8bf9c6506
commit b4296e1c9b
9 changed files with 41 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibPDF/Parser.cpp
View file

@ -101,7 +101,8 @@ PDFErrorOr<Value> Parser::parse_value(CanBeIndirectValue can_be_indirect_value)
if (m_reader.matches('['))
return TRY(parse_array());
return error(DeprecatedString::formatted("Unexpected char \"{}\"", m_reader.peek()));
dbgln_if(PDF_DEBUG, "Unexpected char \"{}\"", m_reader.peek());
return error("Unexpected character");
}
PDFErrorOr<Value> Parser::parse_possible_indirect_value_or_ref()