From b44628c1fb263220df208569edfabe299c289a45 Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Sat, 16 Dec 2023 13:13:10 +0200 Subject: [PATCH] Kernel: Mark sys$join_thread as not needing the big process lock This syscall does not access any big process lock protected resources. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/thread.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index 397b6a7cba..97e8729b0f 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -114,7 +114,7 @@ enum class NeedsBigProcessLock { S(inode_watcher_add_watch, NeedsBigProcessLock::No) \ S(inode_watcher_remove_watch, NeedsBigProcessLock::No) \ S(ioctl, NeedsBigProcessLock::Yes) \ - S(join_thread, NeedsBigProcessLock::Yes) \ + S(join_thread, NeedsBigProcessLock::No) \ S(jail_create, NeedsBigProcessLock::No) \ S(jail_attach, NeedsBigProcessLock::No) \ S(kill, NeedsBigProcessLock::No) \ diff --git a/Kernel/Syscalls/thread.cpp b/Kernel/Syscalls/thread.cpp index 0a317c49e7..5ef2a87aa2 100644 --- a/Kernel/Syscalls/thread.cpp +++ b/Kernel/Syscalls/thread.cpp @@ -137,7 +137,7 @@ ErrorOr Process::sys$detach_thread(pid_t tid) ErrorOr Process::sys$join_thread(pid_t tid, Userspace exit_value) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::thread)); auto thread = TRY(get_thread_from_thread_list(tid));