From b45ca5d56e272c05ccb576c2db8d88ed5211eb3e Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Wed, 15 Sep 2021 23:37:39 -0700 Subject: [PATCH] Kernel+LibC: Pack SC_inode_watcher_add_watch_params struct better Flagged by pvs-studio, ordering the members from largest to smallest allows us to save a few bytes in the size of the struct. --- Kernel/API/Syscall.h | 2 +- Userland/Libraries/LibC/fcntl.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index 955ce205f8..1a2f4e82b1 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -474,8 +474,8 @@ struct SC_set_coredump_metadata_params { }; struct SC_inode_watcher_add_watch_params { - int fd; StringArgument user_path; + int fd; u32 event_mask; }; diff --git a/Userland/Libraries/LibC/fcntl.cpp b/Userland/Libraries/LibC/fcntl.cpp index a4e74fc9ea..47805d0a44 100644 --- a/Userland/Libraries/LibC/fcntl.cpp +++ b/Userland/Libraries/LibC/fcntl.cpp @@ -32,7 +32,7 @@ int create_inode_watcher(unsigned flags) int inode_watcher_add_watch(int fd, const char* path, size_t path_length, unsigned event_mask) { - Syscall::SC_inode_watcher_add_watch_params params { fd, { path, path_length }, event_mask }; + Syscall::SC_inode_watcher_add_watch_params params { { path, path_length }, fd, event_mask }; int rc = syscall(SC_inode_watcher_add_watch, ¶ms); __RETURN_WITH_ERRNO(rc, rc, -1); }