From b47d117bd25ef2d93b4af2bcd94ecad912c7d8e4 Mon Sep 17 00:00:00 2001
From: Gal Horowitz <galush.horowitz@gmail.com>
Date: Fri, 11 Jun 2021 19:40:48 +0300
Subject: [PATCH] LibJS: Add bytecode generation for simple ObjectExpressions

Bytecode is now generated for object literals which only contain simple
key-value pairs (i.e. no spread, getters or setters)
---
 .../Libraries/LibJS/Bytecode/ASTCodegen.cpp   | 28 +++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp b/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
index c7439d26b5..0b63b5a6fc 100644
--- a/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
+++ b/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
@@ -560,9 +560,33 @@ void ForStatement::generate_bytecode(Bytecode::Generator& generator) const
 void ObjectExpression::generate_bytecode(Bytecode::Generator& generator) const
 {
     generator.emit<Bytecode::Op::NewObject>();
+    if (m_properties.is_empty())
+        return;
 
-    if (!m_properties.is_empty())
-        TODO();
+    auto object_reg = generator.allocate_register();
+    generator.emit<Bytecode::Op::Store>(object_reg);
+
+    for (auto& property : m_properties) {
+        if (property.type() != ObjectProperty::Type::KeyValue)
+            TODO();
+
+        if (is<StringLiteral>(property.key())) {
+            auto& string_literal = static_cast<StringLiteral const&>(property.key());
+            Bytecode::StringTableIndex key_name = generator.intern_string(string_literal.value());
+
+            property.value().generate_bytecode(generator);
+            generator.emit<Bytecode::Op::PutById>(object_reg, key_name);
+        } else {
+            property.key().generate_bytecode(generator);
+            auto property_reg = generator.allocate_register();
+            generator.emit<Bytecode::Op::Store>(property_reg);
+
+            property.value().generate_bytecode(generator);
+            generator.emit<Bytecode::Op::PutByValue>(object_reg, property_reg);
+        }
+    }
+
+    generator.emit<Bytecode::Op::Load>(object_reg);
 }
 
 void ArrayExpression::generate_bytecode(Bytecode::Generator& generator) const