RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 21:57:35 +00:00
Code Issues Activity Actions

Kernel/Graphics: Drop support for the DisplayConnector write interface

Browse source 
The WindowServer doesn't use this interface anymore and therefore it's
not used by any userspace application, so let's remove this stale method
to ensure we don't have to bother with it anymore.
This commit is contained in:
Liav A 2022-05-13 03:26:36 +03:00 • committed by Linus Groh
parent f62cd52d12
commit b4e409f721
1 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Kernel/Graphics/DisplayConnector.cpp
View file

@ -48,18 +48,10 @@ ErrorOr<size_t> DisplayConnector::read(OpenFileDescription&, u64, UserOrKernelBu
{ {
return Error::from_errno(ENOTIMPL); return Error::from_errno(ENOTIMPL);
} }
ErrorOr<size_t> DisplayConnector::write(OpenFileDescription&, u64 offset, UserOrKernelBuffer const& framebuffer_data, size_t length)
ErrorOr<size_t> DisplayConnector::write(OpenFileDescription&, u64, UserOrKernelBuffer const&, size_t)
{ {
SpinlockLocker locker(m_control_lock); return Error::from_errno(ENOTIMPL);
// FIXME: We silently ignore the request if we are in console mode.
// WindowServer is not ready yet to handle errors such as EBUSY currently.
if (console_mode()) {
return length;
}
if (offset + length > m_framebuffer_region->size())
return Error::from_errno(EOVERFLOW);
TRY(framebuffer_data.read(m_framebuffer_data + offset, 0, length));
return length;
} }
void DisplayConnector::will_be_destroyed() void DisplayConnector::will_be_destroyed()