mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 14:57:35 +00:00
AudioServer+Userland: Decouple client sample rates from device rate
This change was a long time in the making ever since we obtained sample rate awareness in the system. Now, each client has its own sample rate, accessible via new IPC APIs, and the device sample rate is only accessible via the management interface. AudioServer takes care of resampling client streams into the device sample rate. Therefore, the main improvement introduced with this commit is full responsiveness to sample rate changes; all open audio programs will continue to play at correct speed with the audio resampled to the new device rate. The immediate benefits are manifold: - Gets rid of the legacy hardware sample rate IPC message in the non-managing client - Removes duplicate resampling and sample index rescaling code everywhere - Avoids potential sample index scaling bugs in SoundPlayer (which have happened many times before) and fixes a sample index scaling bug in aplay - Removes several FIXMEs - Reduces amount of sample copying in all applications (especially Piano, where this is critical), improving performance - Reduces number of resampling users, making future API changes (which will need to happen for correct resampling to be implemented) easier I also threw in a simple race condition fix for Piano's audio player loop.
This commit is contained in:
parent
d52a2ff10e
commit
b4fbd30b70
20 changed files with 100 additions and 93 deletions
|
@ -23,9 +23,9 @@ public:
|
|||
|
||||
virtual ~AudioCodecPlugin();
|
||||
|
||||
static ErrorOr<FixedArray<Audio::Sample>> read_samples_from_loader(Audio::Loader&, size_t samples_to_load, size_t device_sample_rate);
|
||||
static Duration set_loader_position(Audio::Loader&, double position, Duration duration, size_t device_sample_rate);
|
||||
static Duration current_loader_position(Audio::Loader const&, size_t device_sample_rate);
|
||||
static ErrorOr<FixedArray<Audio::Sample>> read_samples_from_loader(Audio::Loader&, size_t samples_to_load);
|
||||
static Duration set_loader_position(Audio::Loader&, double position, Duration duration);
|
||||
static Duration current_loader_position(Audio::Loader const&);
|
||||
|
||||
virtual void resume_playback() = 0;
|
||||
virtual void pause_playback() = 0;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue