RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:27:43 +00:00
Code Issues Activity Actions

Kernel: Mark sys$chmod() as not needing the big lock

Browse source 
This syscall doesn't access any data that was implicitly protected by
the big lock.
This commit is contained in:
Andreas Kling 2022-03-08 16:36:42 +01:00
parent aa381c4a67
commit b4fefedd1d
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -49,7 +49,7 @@ enum class NeedsBigProcessLock {
S(beep, NeedsBigProcessLock::No) \ S(beep, NeedsBigProcessLock::No) \
S(bind, NeedsBigProcessLock::Yes) \ S(bind, NeedsBigProcessLock::Yes) \
S(chdir, NeedsBigProcessLock::No) \ S(chdir, NeedsBigProcessLock::No) \
S(chmod, NeedsBigProcessLock::Yes) \ S(chmod, NeedsBigProcessLock::No) \
S(chown, NeedsBigProcessLock::Yes) \ S(chown, NeedsBigProcessLock::Yes) \
S(clock_gettime, NeedsBigProcessLock::No) \ S(clock_gettime, NeedsBigProcessLock::No) \
S(clock_nanosleep, NeedsBigProcessLock::No) \ S(clock_nanosleep, NeedsBigProcessLock::No) \

2
Kernel/Syscalls/chmod.cpp
View file

@ -13,7 +13,7 @@ namespace Kernel {
ErrorOr<FlatPtr> Process::sys$chmod(Userspace<Syscall::SC_chmod_params const*> user_params) ErrorOr<FlatPtr> Process::sys$chmod(Userspace<Syscall::SC_chmod_params const*> user_params)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); VERIFY_NO_PROCESS_BIG_LOCK(this);
TRY(require_promise(Pledge::fattr)); TRY(require_promise(Pledge::fattr));
auto params = TRY(copy_typed_from_user(user_params)); auto params = TRY(copy_typed_from_user(user_params));
auto path = TRY(get_syscall_path_argument(params.path)); auto path = TRY(get_syscall_path_argument(params.path));