RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:37:45 +00:00
Code Issues Activity Actions

Spreadsheet: Clear callbacks on persistent widgets before tearing tabs down

Browse source 
Otherwise changes to the widgets would cause all sorts of updates on
half-deleted cells.
Fixes #4171.
This commit is contained in:
AnotherTest 2020-11-29 17:27:08 +03:30 • committed by Andreas Kling
parent a20f1202a8
commit b532b2d3ca
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Applications/Spreadsheet/SpreadsheetWidget.cpp
View file

@ -175,6 +175,11 @@ void SpreadsheetWidget::load(const StringView& filename)
GUI::MessageBox::show_error(window(), result.error());
return;
}
m_tab_widget->on_change = nullptr;
m_cell_value_editor->on_change = nullptr;
m_current_cell_label->set_text("");
m_should_change_selected_cells = false;
while (auto* widget = m_tab_widget->active_widget()) {
m_tab_widget->remove_tab(*widget);
}