RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 17:18:11 +00:00
Code Issues Activity Actions

LibWasm: Give traps a reason and display it when needed

Browse source 
This makes debugging wasm code a bit easier, as we now know what fails
instead of just "too bad, something went wrong".
This commit is contained in:
Ali Mohammad Pur 2021-07-01 17:03:17 +04:30 • committed by Ali Mohammad Pur
parent 62ca81fdcc
commit b538e15548
10 changed files with 54 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWasm/AbstractMachine/Configuration.cpp
View file

@ -68,10 +68,10 @@ Result Configuration::execute(Interpreter& interpreter)
{
interpreter.interpret(*this);
if (interpreter.did_trap())
return Trap {};
return Trap { interpreter.trap_reason() };
if (stack().size() <= frame().arity() + 1)
return Trap {};
return Trap { "Not enough values to return from call" };
Vector<Value> results;
results.ensure_capacity(frame().arity());
@ -80,7 +80,7 @@ Result Configuration::execute(Interpreter& interpreter)
auto label = stack().pop();
// ASSERT: label == current frame
if (!label.has<Label>())
return Trap {};
return Trap { "Invalid stack configuration" };
return Result { move(results) };
}