RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:58:12 +00:00
Code Issues Activity Actions

Browser+WebContent+WebDriver: Move Get/Set Window Rect to WebContent

Browse source 
This also lets us more fully implement the "restore the window" method,
which requires we block until the document reaches the "visible" state.
This commit is contained in:
Timothy Flynn 2022-11-09 09:56:20 -05:00 • committed by Linus Groh
parent 9505928fdb
commit b57d7e4332
10 changed files with 144 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Services/WebDriver/Client.cpp
View file

@ -582,8 +582,7 @@ Web::WebDriver::Response Client::handle_get_window_rect(Vector<StringView> const
{
dbgln_if(WEBDRIVER_DEBUG, "Handling GET /session/<session_id>/window/rect");
auto* session = TRY(find_session_with_id(parameters[0]));
auto result = TRY(session->get_window_rect());
return make_json_value(result);
return session->web_content_connection().get_window_rect();
}
// 11.8.2 Set Window Rect, https://w3c.github.io/webdriver/#dfn-set-window-rect
@ -592,8 +591,7 @@ Web::WebDriver::Response Client::handle_set_window_rect(Vector<StringView> const
{
dbgln_if(WEBDRIVER_DEBUG, "Handling POST /session/<session_id>/window/rect");
auto* session = TRY(find_session_with_id(parameters[0]));
auto result = TRY(session->set_window_rect(payload));
return make_json_value(result);
return session->web_content_connection().set_window_rect(payload);
}
// 11.8.3 Maximize Window, https://w3c.github.io/webdriver/#dfn-maximize-window