RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 16:18:12 +00:00
Code Issues Activity Actions

Kernel: Scroll wheel amount on Intellimouse is 4 bits instead of 8

Browse source 
When trying to scroll up on virtualizers that don't use the VMware
backdoor and instead use PS2MouseDevice, it would actually scroll
down rapidly.

Looking into it, the mouse delta for scrolling down was 1 and 15
for scrolling up. 15 is suspiciously -1 for a nibble.

According to https://isdaman.com/alsos/hardware/mouse/ps2interface.htm
the Z is actually 4 bits for Intellimouse.

This fixes scrolling up on virtualizers such as VirtualBox.
This commit is contained in:
Luke 2020-08-25 05:51:15 +01:00 • committed by Andreas Kling
parent 8b166e57df
commit b58ca7cf3d
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Kernel/Devices/PS2MouseDevice.cpp
View file

@ -136,8 +136,15 @@ void PS2MouseDevice::parse_data_packet()
int x = m_data[1];
int y = m_data[2];
int z = 0;
if (m_has_wheel)
z = (char)m_data[3];
if (m_has_wheel) {
// FIXME: For non-Intellimouse, this is a full byte.
// However, for now, m_has_wheel is only set for Intellimouse.
z = (char)(m_data[3] & 0x0f);
// -1 in 4 bits
if (z == 15)
z = -1;
}
bool x_overflow = m_data[0] & 0x40;
bool y_overflow = m_data[0] & 0x80;
bool x_sign = m_data[0] & 0x10;