RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 20:28:11 +00:00
Code Issues Activity Actions

Replace various copies of parse_uint(String) with String::to_uint().

Browse source
This commit is contained in:
Andreas Kling 2019-05-08 19:21:51 +02:00
parent cea631d90c
commit b5b44a29bb
4 changed files with 6 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/kill.cpp
View file

@ -4,25 +4,6 @@
#include <stdlib.h>
#include <AK/AKString.h>
static unsigned parse_uint(const String& str, bool& ok)
{
if (str.is_empty()) {
ok = false;
return 0;
}
unsigned value = 0;
for (int i = 0; i < str.length(); ++i) {
if (str[i] < '0' || str[i] > '9') {
ok = false;
return 0;
}
value = value * 10;
value += (unsigned)(str[i] - '0');
}
ok = true;
return value;
}
static void print_usage_and_exit()
{
printf("usage: kill [-signal] <PID>\n");
@ -40,13 +21,13 @@ int main(int argc, char** argv)
pid_argi = 2;
if (argv[1][0] != '-')
print_usage_and_exit();
signum = parse_uint(&argv[1][1], ok);
signum = String(&argv[1][1]).to_uint(ok);
if (!ok) {
printf("'%s' is not a valid signal number\n", &argv[1][1]);
return 2;
}
}
unsigned pid = parse_uint(argv[pid_argi], ok);
unsigned pid = String(argv[pid_argi]).to_uint(ok);
if (!ok) {
printf("'%s' is not a valid PID\n", argv[pid_argi]);
return 3;