RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:07:34 +00:00
Code Issues Activity Actions

SystemServer: Handle missing service executable gracefully

Browse source 
I use the `configure-components` functionality locally during
development. There are a few services (SpiceAgent) which aren't marked
as required components, and hence aren't built in all configurations,
but we still try to launch them in all configurations.

Instead of letting the forked SystemServer process crash, lets
gracefully handle the situation of a missing binary and provide a
message to the user.
This commit is contained in:
Brian Gianforcaro 2021-08-07 03:10:45 -07:00 • committed by Gunnar Beutner
parent 5acb7e4eba
commit b5b67a1747
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Services/SystemServer/Service.cpp
View file

@ -131,6 +131,11 @@ void Service::activate()
void Service::spawn(int socket_fd)
{
if (!Core::File::exists(m_executable_path)) {
dbgln("{}: binary \"{}\" does not exist, skipping service.", name(), m_executable_path);
return;
}
dbgln_if(SERVICE_DEBUG, "Spawning {}", name());
m_run_timer.start();