RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:57:35 +00:00
Code Issues Activity Actions

LibJS: Don't parse numeric literal containing 8 or 9 as octal

Browse source 
If the value has a leading zero (allowed in non-strict mode) but
contains the digits 8 or 9 it can't be an octal number.
This commit is contained in:
Linus Groh 2020-10-27 19:30:27 +00:00 • committed by Andreas Kling
parent b4e51249e9
commit b5bd05b717
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibJS/Tests/numeric-literals-basic.js
View file

@ -10,6 +10,7 @@ test("octal literals", () => {
expect(0o10).toBe(8); expect(0o10).toBe(8);
expect(0o10).toBe(8); expect(0o10).toBe(8);
expect(010).toBe(8); expect(010).toBe(8);
expect(089).toBe(89);
}); });
test("binary literals", () => { test("binary literals", () => {

3
Libraries/LibJS/Token.cpp
View file

@ -86,7 +86,8 @@ double Token::double_value() const
return static_cast<double>(strtoul(value_string.characters() + 2, nullptr, 2)); return static_cast<double>(strtoul(value_string.characters() + 2, nullptr, 2));
} else if (isdigit(value_string[1])) { } else if (isdigit(value_string[1])) {
// also octal, but syntax error in strict mode // also octal, but syntax error in strict mode
return static_cast<double>(strtoul(value_string.characters() + 1, nullptr, 8)); if (!m_value.contains('8') && !m_value.contains('9'))
return static_cast<double>(strtoul(value_string.characters() + 1, nullptr, 8));
} }
} }
return strtod(value_string.characters(), nullptr); return strtod(value_string.characters(), nullptr);