RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:57:35 +00:00
Code Issues Activity Actions

WebContent: Show box-model metrics for (some) pseudo-elements

Browse source 
This only applies to pseudo-elements which have a Layout::Box, so this
excludes any that are InlineNodes.
This commit is contained in:
Sam Atkins 2022-03-10 11:24:55 +00:00 • committed by Andreas Kling
parent 0326ad34df
commit b5ea14b884
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -302,11 +302,12 @@ Messages::WebContentServer::InspectDomNodeResponse ConnectionFromClient::inspect
return builder.to_string();
};
auto serialize_node_box_sizing_json = [](Web::DOM::Element const& element) -> String {
if (!element.layout_node()) {
auto serialize_node_box_sizing_json = [](Web::Layout::Node const* layout_node) -> String {
if (!layout_node || !layout_node->is_box()) {
return "";
}
auto box_model = static_cast<Web::Layout::Box const&>(*element.layout_node()).box_model();
auto* box = static_cast<Web::Layout::Box const*>(layout_node);
auto box_model = box->box_model();
StringBuilder builder;
auto serializer = MUST(JsonObjectSerializer<>::try_create(builder));
MUST(serializer.add("padding_top", box_model.padding.top));
@ -321,8 +322,8 @@ Messages::WebContentServer::InspectDomNodeResponse ConnectionFromClient::inspect
MUST(serializer.add("border_right", box_model.border.right));
MUST(serializer.add("border_bottom", box_model.border.bottom));
MUST(serializer.add("border_left", box_model.border.left));
MUST(serializer.add("content_width", static_cast<Web::Layout::Box const&>(*element.layout_node()).content_width()));
MUST(serializer.add("content_height", static_cast<Web::Layout::Box const&>(*element.layout_node()).content_height()));
MUST(serializer.add("content_width", box->content_width()));
MUST(serializer.add("content_height", box->content_height()));
MUST(serializer.finish());
return builder.to_string();
@ -340,14 +341,14 @@ Messages::WebContentServer::InspectDomNodeResponse ConnectionFromClient::inspect
String specified_values_json = serialize_json(pseudo_element_style);
String computed_values_json = "{}";
String custom_properties_json = "{}";
String node_box_sizing_json = "{}";
String node_box_sizing_json = serialize_node_box_sizing_json(pseudo_element_node.ptr());
return { true, specified_values_json, computed_values_json, custom_properties_json, node_box_sizing_json };
}
String specified_values_json = serialize_json(*element.specified_css_values());
String computed_values_json = serialize_json(element.computed_style());
String custom_properties_json = serialize_custom_properties_json(element);
String node_box_sizing_json = serialize_node_box_sizing_json(element);
String node_box_sizing_json = serialize_node_box_sizing_json(element.layout_node());
return { true, specified_values_json, computed_values_json, custom_properties_json, node_box_sizing_json };
}