RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00
Code Issues Activity Actions

LibWeb: Implement automatic slottable assignment

Browse source 
This implements automatic slottable assignment by way of hooking into
the element attribute change steps. When the `name` attribute of a slot
or the `slot` attribute of a slottable changes, assignment is performed.
This commit is contained in:
Timothy Flynn 2023-09-05 15:08:35 -04:00 • committed by Andreas Kling
parent e9da74ebe0
commit b602ee7ddd
3 changed files with 85 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Userland/Libraries/LibWeb/DOM/Slottable.cpp
View file

@ -84,8 +84,19 @@ JS::GCPtr<HTML::HTMLSlotElement> find_a_slot(Slottable const& slottable, OpenFla
return slot;
}
// FIXME: 6. Return the first slot in tree order in shadow’s descendants whose name is slottable’s name, if any; otherwise null.
return nullptr;
// 6. Return the first slot in tree order in shadow’s descendants whose name is slottable’s name, if any; otherwise null.
auto const& slottable_name = slottable.visit([](auto const& node) { return node->slottable_name(); });
JS::GCPtr<HTML::HTMLSlotElement> slot;
shadow->for_each_in_subtree_of_type<HTML::HTMLSlotElement>([&](auto& child) {
if (child.slot_name() != slottable_name)
return IterationDecision::Continue;
slot = child;
return IterationDecision::Break;
});
return slot;
}
// https://dom.spec.whatwg.org/#find-slotables
@ -118,8 +129,19 @@ Vector<Slottable> find_slottables(JS::NonnullGCPtr<HTML::HTMLSlotElement> slot)
}
// 6. Otherwise, for each slottable child slottable of host, in tree order:
else {
// FIXME: 1. Let foundSlot be the result of finding a slot given slottable.
// FIXME: 2. If foundSlot is slot, then append slottable to result.
host->for_each_child([&](auto& node) {
if (!node.is_slottable())
return;
auto slottable = node.as_slottable();
// 1. Let foundSlot be the result of finding a slot given slottable.
auto found_slot = find_a_slot(slottable);
// 2. If foundSlot is slot, then append slottable to result.
if (found_slot == slot)
result.append(move(slottable));
});
}
// 7. Return result.