RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:07:36 +00:00
Code Issues Activity Actions

LibGfx: Use StringView for header constants in the GIF decoder

Browse source
This commit is contained in:
Andreas Kling 2021-11-20 16:18:28 +01:00
parent 2482966db9
commit b6359b211d
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGfx/GIFLoader.cpp
View file

@ -87,8 +87,8 @@ enum class GIFFormat {
static Optional<GIFFormat> decode_gif_header(InputMemoryStream& stream) static Optional<GIFFormat> decode_gif_header(InputMemoryStream& stream)
{ {
static const char valid_header_87[] = "GIF87a"; static auto valid_header_87 = "GIF87a"sv;
static const char valid_header_89[] = "GIF89a"; static auto valid_header_89 = "GIF89a"sv;
Array<u8, 6> header; Array<u8, 6> header;
stream >> header; stream >> header;
@ -96,9 +96,9 @@ static Optional<GIFFormat> decode_gif_header(InputMemoryStream& stream)
if (stream.handle_any_error()) if (stream.handle_any_error())
return {}; return {};
if (header.span() == ReadonlyBytes { valid_header_87, 6 }) if (header.span() == valid_header_87.bytes())
return GIFFormat::GIF87a; return GIFFormat::GIF87a;
if (header.span() == ReadonlyBytes { valid_header_89, 6 }) if (header.span() == valid_header_89.bytes())
return GIFFormat::GIF89a; return GIFFormat::GIF89a;
return {}; return {};