RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

Kernel/FileSystem: Enforce locking of m_inode_lock when truncating Inode

Browse source 
Such operation is almost equivalent to writing on an Inode, so lock the
Inode m_inode_lock exclusively.
All FileSystem Inode implementations then override a new method called
truncate_locked which should implement the actual truncating.
This commit is contained in:
Liav A 2024-02-10 12:49:31 +02:00 • committed by Andrew Kaster
parent 53dd04e219
commit b63a1dda63
13 changed files with 23 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/Ext2FS/Inode.cpp
View file

@ -1071,9 +1071,9 @@ ErrorOr<void> Ext2FSInode::chown(UserID uid, GroupID gid)
return {};
}
ErrorOr<void> Ext2FSInode::truncate(u64 size)
ErrorOr<void> Ext2FSInode::truncate_locked(u64 size)
{
MutexLocker locker(m_inode_lock);
VERIFY(m_inode_lock.is_locked());
if (static_cast<u64>(m_raw_inode.i_size) == size)
return {};
TRY(resize(size));

2
Kernel/FileSystem/Ext2FS/Inode.h
View file

@ -42,7 +42,7 @@ private:
virtual ErrorOr<void> decrement_link_count() override;
virtual ErrorOr<void> chmod(mode_t) override;
virtual ErrorOr<void> chown(UserID, GroupID) override;
virtual ErrorOr<void> truncate(u64) override;
virtual ErrorOr<void> truncate_locked(u64) override;
virtual ErrorOr<int> get_block_address(int) override;
ErrorOr<void> write_directory(Vector<Ext2FSDirectoryEntry>&);