RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:07:36 +00:00
Code Issues Activity Actions

Kernel/FileSystem: Enforce locking of m_inode_lock when truncating Inode

Browse source 
Such operation is almost equivalent to writing on an Inode, so lock the
Inode m_inode_lock exclusively.
All FileSystem Inode implementations then override a new method called
truncate_locked which should implement the actual truncating.
This commit is contained in:
Liav A 2024-02-10 12:49:31 +02:00 • committed by Andrew Kaster
parent 53dd04e219
commit b63a1dda63
13 changed files with 23 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/FileSystem/Plan9FS/Inode.cpp
View file

@ -284,8 +284,9 @@ ErrorOr<void> Plan9FSInode::chown(UserID, GroupID)
return ENOTIMPL;
}
ErrorOr<void> Plan9FSInode::truncate(u64 new_size)
ErrorOr<void> Plan9FSInode::truncate_locked(u64 new_size)
{
VERIFY(m_inode_lock.is_locked());
if (fs().m_remote_protocol_version >= Plan9FS::ProtocolVersion::v9P2000L) {
Plan9FSMessage message { fs(), Plan9FSMessage::Type::Tsetattr };
SetAttrMask valid = SetAttrMask::Size;

2
Kernel/FileSystem/Plan9FS/Inode.h
View file

@ -33,7 +33,7 @@ public:
virtual ErrorOr<void> replace_child(StringView name, Inode& child) override;
virtual ErrorOr<void> chmod(mode_t) override;
virtual ErrorOr<void> chown(UserID, GroupID) override;
virtual ErrorOr<void> truncate(u64) override;
virtual ErrorOr<void> truncate_locked(u64) override;
private:
// ^Inode